Re: hbase shell broken in trunk (with simple patch)

[lars hofhansl <lh...@yahoo.com>]

Err... It did say 

ERROR: undefined method `getZooKeeper' for #<Java::OrgApacheHadoopHbaseZookeeper::ZooKeeperWatcher:0x1c904f75>

Pasted the wrong message. Also fixed subject.


----- Original Message -----
From: lars hofhansl <lh...@yahoo.com>
To: "user@hbase.apache.org" <us...@hbase.apache.org>
Cc: 
Sent: Friday, August 5, 2011 7:01 PM
Subject: hbase shell broken in truck (with simple patch)

I noticed in HBase trunk I always get this error in the shell:

ERROR: undefined method `getRecoverableZookeeper' for #<Java::OrgApacheHadoopHbaseZookeeper::ZooKeeperWatcher:0x1c904f75>


This is apparently caused by HBASE-3065. The fix is trivial:

Index: src/main/ruby/hbase/admin.rb
===================================================================
--- src/main/ruby/hbase/admin.rb        (revision 1154413)
+++ src/main/ruby/hbase/admin.rb        (working copy)
@@ -30,7 +30,7 @@
       @admin = org.apache.hadoop.hbase.client.HBaseAdmin.new(configuration)
       connection = @admin.getConnection()
       @zk_wrapper = connection.getZooKeeperWatcher()
-      zk = @zk_wrapper.getZooKeeper()
+      zk = @zk_wrapper.getRecoverableZooKeeper().getZooKeeper()
       @zk_main = org.apache.zookeeper.ZooKeeperMain.new(zk)
       @formatter = formatter
     end

Should I open an issue and add the patch there?

Thanks.

-- Lars