You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jens Deppe <jd...@pivotal.io> on 2016/06/01 18:49:48 UTC

Review Request 48148: GEODE-1179: Remove references to vsd

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48148/
-----------------------------------------------------------

Review request for geode, Jinmei Liao, Kevin Duling, and Kirk Lund.


Repository: geode


Description
-------

- Also removed lingering references to DataBrowser


Diffs
-----

  geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/Launcher.java 5d57db6c31585cf63b4fdab4ff328fb9c9c2d94e 
  geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommands.java eca3e65ff7ffe27a9d1b4c954ea7b6cf64e7c5d6 
  geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/i18n/CliStrings.java 241c9e217efb05ad1cb8bb5458cb86121e7848f9 
  geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/TestCommand.java 2ddc6eee691b7305a0618f9a40e03a39526bc7b5 
  geode-core/src/test/resources/com/gemstone/gemfire/management/internal/cli/commands/golden-help-offline.properties 74db3930d216fffa57342d215a520b935980d5e1 
  geode-core/src/test/resources/com/gemstone/gemfire/management/internal/cli/commands/golden-help-online.properties 57f8f37c5df5840895d8d3374502884f95ed9829 

Diff: https://reviews.apache.org/r/48148/diff/


Testing
-------


Thanks,

Jens Deppe


Re: Review Request 48148: GEODE-1179: Remove references to vsd

Posted by Kirk Lund <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48148/#review135947
-----------------------------------------------------------


Ship it!




Ship It!

- Kirk Lund


On June 1, 2016, 6:49 p.m., Jens Deppe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48148/
> -----------------------------------------------------------
> 
> (Updated June 1, 2016, 6:49 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Kevin Duling, and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> - Also removed lingering references to DataBrowser
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/Launcher.java 5d57db6c31585cf63b4fdab4ff328fb9c9c2d94e 
>   geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommands.java eca3e65ff7ffe27a9d1b4c954ea7b6cf64e7c5d6 
>   geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/i18n/CliStrings.java 241c9e217efb05ad1cb8bb5458cb86121e7848f9 
>   geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/TestCommand.java 2ddc6eee691b7305a0618f9a40e03a39526bc7b5 
>   geode-core/src/test/resources/com/gemstone/gemfire/management/internal/cli/commands/golden-help-offline.properties 74db3930d216fffa57342d215a520b935980d5e1 
>   geode-core/src/test/resources/com/gemstone/gemfire/management/internal/cli/commands/golden-help-online.properties 57f8f37c5df5840895d8d3374502884f95ed9829 
> 
> Diff: https://reviews.apache.org/r/48148/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jens Deppe
> 
>


Re: Review Request 48148: GEODE-1179: Remove references to vsd

Posted by Dave Barnes <db...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48148/#review135866
-----------------------------------------------------------


Ship it!




- Dave Barnes


On June 1, 2016, 6:49 p.m., Jens Deppe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48148/
> -----------------------------------------------------------
> 
> (Updated June 1, 2016, 6:49 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Kevin Duling, and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> - Also removed lingering references to DataBrowser
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/Launcher.java 5d57db6c31585cf63b4fdab4ff328fb9c9c2d94e 
>   geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommands.java eca3e65ff7ffe27a9d1b4c954ea7b6cf64e7c5d6 
>   geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/i18n/CliStrings.java 241c9e217efb05ad1cb8bb5458cb86121e7848f9 
>   geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/TestCommand.java 2ddc6eee691b7305a0618f9a40e03a39526bc7b5 
>   geode-core/src/test/resources/com/gemstone/gemfire/management/internal/cli/commands/golden-help-offline.properties 74db3930d216fffa57342d215a520b935980d5e1 
>   geode-core/src/test/resources/com/gemstone/gemfire/management/internal/cli/commands/golden-help-online.properties 57f8f37c5df5840895d8d3374502884f95ed9829 
> 
> Diff: https://reviews.apache.org/r/48148/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jens Deppe
> 
>


Re: Review Request 48148: GEODE-1179: Remove references to vsd

Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48148/#review135844
-----------------------------------------------------------


Ship it!




Ship It!

- Jinmei Liao


On June 1, 2016, 6:49 p.m., Jens Deppe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48148/
> -----------------------------------------------------------
> 
> (Updated June 1, 2016, 6:49 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Kevin Duling, and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> - Also removed lingering references to DataBrowser
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/Launcher.java 5d57db6c31585cf63b4fdab4ff328fb9c9c2d94e 
>   geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommands.java eca3e65ff7ffe27a9d1b4c954ea7b6cf64e7c5d6 
>   geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/i18n/CliStrings.java 241c9e217efb05ad1cb8bb5458cb86121e7848f9 
>   geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/TestCommand.java 2ddc6eee691b7305a0618f9a40e03a39526bc7b5 
>   geode-core/src/test/resources/com/gemstone/gemfire/management/internal/cli/commands/golden-help-offline.properties 74db3930d216fffa57342d215a520b935980d5e1 
>   geode-core/src/test/resources/com/gemstone/gemfire/management/internal/cli/commands/golden-help-online.properties 57f8f37c5df5840895d8d3374502884f95ed9829 
> 
> Diff: https://reviews.apache.org/r/48148/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jens Deppe
> 
>