You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Aron Hamvas via Review Board <no...@reviews.apache.org> on 2019/10/30 13:50:33 UTC
Review Request 71705: HIVE-22420: DbTxnManager.stopHeartbeat() should
be thread-safe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71705/
-----------------------------------------------------------
Review request for hive, Denys Kuzmenko, Marta Kuczora, Laszlo Pinter, and Peter Vary.
Bugs: HIVE-22420
https://issues.apache.org/jira/browse/HIVE-22420
Repository: hive-git
Description
-------
DbTxnManager.stopHeartbeat() should be thread-safe, rollbackTxn() should check before calling MS client, if txn has been closed previously, to avoid sending 0 as txnId.
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java 943aa383bb
Diff: https://reviews.apache.org/r/71705/diff/1/
Testing
-------
Thanks,
Aron Hamvas
Re: Review Request 71705: HIVE-22420: DbTxnManager.stopHeartbeat()
should be thread-safe
Posted by Denys Kuzmenko via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71705/#review218491
-----------------------------------------------------------
LGTM, just minor comments. Also you mentioned unit test, do not see it in a patch.
- Denys Kuzmenko
On Nov. 4, 2019, 10:02 a.m., Aron Hamvas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71705/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2019, 10:02 a.m.)
>
>
> Review request for hive, Denys Kuzmenko, Marta Kuczora, Laszlo Pinter, and Peter Vary.
>
>
> Bugs: HIVE-22420
> https://issues.apache.org/jira/browse/HIVE-22420
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> DbTxnManager.stopHeartbeat() should be thread-safe, rollbackTxn() should check before calling MS client, if txn has been closed previously, to avoid sending 0 as txnId.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java 943aa383bb
>
>
> Diff: https://reviews.apache.org/r/71705/diff/2/
>
>
> Testing
> -------
>
> unit test
>
>
> Thanks,
>
> Aron Hamvas
>
>
Re: Review Request 71705: HIVE-22420: DbTxnManager.stopHeartbeat()
should be thread-safe
Posted by Denys Kuzmenko via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71705/#review218490
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java
Lines 539 (patched)
<https://reviews.apache.org/r/71705/#comment306237>
should it be thread safe?
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java
Lines 677 (patched)
<https://reviews.apache.org/r/71705/#comment306235>
Magic number. Why exactly 31 sec?
- Denys Kuzmenko
On Nov. 4, 2019, 10:02 a.m., Aron Hamvas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71705/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2019, 10:02 a.m.)
>
>
> Review request for hive, Denys Kuzmenko, Marta Kuczora, Laszlo Pinter, and Peter Vary.
>
>
> Bugs: HIVE-22420
> https://issues.apache.org/jira/browse/HIVE-22420
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> DbTxnManager.stopHeartbeat() should be thread-safe, rollbackTxn() should check before calling MS client, if txn has been closed previously, to avoid sending 0 as txnId.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java 943aa383bb
>
>
> Diff: https://reviews.apache.org/r/71705/diff/2/
>
>
> Testing
> -------
>
> unit test
>
>
> Thanks,
>
> Aron Hamvas
>
>
Re: Review Request 71705: HIVE-22420: DbTxnManager.stopHeartbeat()
should be thread-safe
Posted by Aron Hamvas via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71705/
-----------------------------------------------------------
(Updated Nov. 4, 2019, 10:02 a.m.)
Review request for hive, Denys Kuzmenko, Marta Kuczora, Laszlo Pinter, and Peter Vary.
Changes
-------
Do not allow starting multiple heartbeater tasks.
Bugs: HIVE-22420
https://issues.apache.org/jira/browse/HIVE-22420
Repository: hive-git
Description
-------
DbTxnManager.stopHeartbeat() should be thread-safe, rollbackTxn() should check before calling MS client, if txn has been closed previously, to avoid sending 0 as txnId.
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java 943aa383bb
Diff: https://reviews.apache.org/r/71705/diff/2/
Changes: https://reviews.apache.org/r/71705/diff/1-2/
Testing
-------
unit test
Thanks,
Aron Hamvas