[GitHub] [tvm] mehrdadh edited a comment on pull request #10520: [Hexagon] Resolve breakage in test_hexagon/test_cache_read_write

[GitBox <gi...@apache.org>]

mehrdadh edited a comment on pull request #10520:
URL: https://github.com/apache/tvm/pull/10520#issuecomment-1061153486


   I think the reason that CI didn't catch this is because we don't run this test in CI. We need fix this in both of these files:
   https://github.com/apache/tvm/blob/main/tests/scripts/task_python_hexagon.sh
   https://github.com/apache/tvm/blob/main/tests/scripts/task_python_hexagon_simulator.sh
   Basically, we need to run the test on the directory instead of the pytest file. So:
   
   ```
   --- a/tests/scripts/task_python_hexagon.sh
   +++ b/tests/scripts/task_python_hexagon.sh
   @@ -25,4 +25,4 @@ make cython3
    
   -run_pytest ctypes python-contrib-hexagon-no-hwardware tests/python/contrib/test_hexagon/test_launcher.py
   +run_pytest ctypes python-contrib-hexagon-no-hwardware tests/python/contrib/test_hexagon
   ```
   
   @Lunderberg can you add it to this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org