You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "Tsz Wo Nicholas Sze (JIRA)" <ji...@apache.org> on 2018/09/17 23:22:00 UTC

[jira] [Commented] (RATIS-324) Rename grpc classes

    [ https://issues.apache.org/jira/browse/RATIS-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16618273#comment-16618273 ] 

Tsz Wo Nicholas Sze commented on RATIS-324:
-------------------------------------------

Below are the proposed class names:

- RaftGrpcUtil.java -> GrpcUtil.java
- client/RaftClientProtocolClient.java -> client/GrpcClientProtocolClient.java
- client/RaftClientProtocolProxy.java -> client/GrpcClientProtocolProxy.java
- client/RaftClientProtocolService.java -> client/GrpcClientProtocolService.java
- client/AppendStreamer.java -> client/GrpcClientStreamer.java
- client/RaftOutputStream.java -> client/GrpcOutputStream.java
- server/AdminProtocolService.java -> server/GrpcAdminProtocolService.java
- server/GRpcLogAppender.java -> server/GrpcLogAppender.java
- server/RaftServerProtocolClient.java -> server/GrpcServerProtocolClient.java
- server/RaftServerProtocolService.java -> server/GrpcServerProtocolService.java
- RaftGRpcService.java -> server/GrpcService.java
- MiniRaftClusterWithGRpc.java -> MiniRaftClusterWithGrpc.java
- TestRaftReconfigurationWithGRpc.java -> TestRaftReconfigurationWithGrpc.java
- ratis-proto-shaded/src/main/proto/GRpc.proto -> ratis-proto-shaded/src/main/proto/Grpc.proto



> Rename grpc classes
> -------------------
>
>                 Key: RATIS-324
>                 URL: https://issues.apache.org/jira/browse/RATIS-324
>             Project: Ratis
>          Issue Type: Improvement
>          Components: gRPC
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Tsz Wo Nicholas Sze
>            Priority: Major
>
> The grpc class names are inconsistent:
> - Inconsistent capitalization: GRpc vs Grpc
> - Some name are confusing such as RaftClientProtocolProxy and AppendStreamer.
> Also, RaftGRpcService should be moved to the server package.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)