You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/17 19:06:21 UTC
[GitHub] [flink] GJL opened a new pull request #12204: [FLINK-17777][tests] Set HADOOP_CLASSPATH for Mesos TaskManagers
GJL opened a new pull request #12204:
URL: https://github.com/apache/flink/pull/12204
## What is the purpose of the change
*This sets the `HADOOP_CLASSPATH` for Mesos TaskMangers*
## Brief change log
- *Enable overriding Flink configuration for different Flink deployment scenarios.*
- *Use `containerized.taskmanager.env.HADOOP_CLASSPATH` config option to set the `HADOOP_CLASSPATH` environment variable for Mesos TaskManagers.*
- *Remove unnecessary config options from default Flink configuration.*
## Verifying this change
This change is already covered by existing tests, such as *flink-jepsen*.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] GJL closed pull request #12204: [FLINK-17777][tests] Set HADOOP_CLASSPATH for Mesos TaskManagers
Posted by GitBox <gi...@apache.org>.
GJL closed pull request #12204:
URL: https://github.com/apache/flink/pull/12204
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12204: [FLINK-17777][tests] Set HADOOP_CLASSPATH for Mesos TaskManagers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12204:
URL: https://github.com/apache/flink/pull/12204#issuecomment-629845444
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 902a4ce39e99cb0becc8a709e423fcd406752ae2 (Fri Oct 16 10:48:41 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12204: [FLINK-17777][tests] Set HADOOP_CLASSPATH for Mesos TaskManagers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12204:
URL: https://github.com/apache/flink/pull/12204#issuecomment-629847515
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "097ac2b06f10900c435115c24e699c5328ee3227",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1649",
"triggerID" : "097ac2b06f10900c435115c24e699c5328ee3227",
"triggerType" : "PUSH"
}, {
"hash" : "1b0f95eb45256569484cff22599d080d968841f0",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1704",
"triggerID" : "1b0f95eb45256569484cff22599d080d968841f0",
"triggerType" : "PUSH"
}, {
"hash" : "902a4ce39e99cb0becc8a709e423fcd406752ae2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1723",
"triggerID" : "902a4ce39e99cb0becc8a709e423fcd406752ae2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1b0f95eb45256569484cff22599d080d968841f0 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1704)
* 902a4ce39e99cb0becc8a709e423fcd406752ae2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1723)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12204: [FLINK-17777][tests] Set HADOOP_CLASSPATH for Mesos TaskManagers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12204:
URL: https://github.com/apache/flink/pull/12204#issuecomment-629847515
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "097ac2b06f10900c435115c24e699c5328ee3227",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1649",
"triggerID" : "097ac2b06f10900c435115c24e699c5328ee3227",
"triggerType" : "PUSH"
}, {
"hash" : "1b0f95eb45256569484cff22599d080d968841f0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1704",
"triggerID" : "1b0f95eb45256569484cff22599d080d968841f0",
"triggerType" : "PUSH"
}, {
"hash" : "902a4ce39e99cb0becc8a709e423fcd406752ae2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "902a4ce39e99cb0becc8a709e423fcd406752ae2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 097ac2b06f10900c435115c24e699c5328ee3227 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1649)
* 1b0f95eb45256569484cff22599d080d968841f0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1704)
* 902a4ce39e99cb0becc8a709e423fcd406752ae2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12204: [FLINK-17777][tests] Set HADOOP_CLASSPATH for Mesos TaskManagers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12204:
URL: https://github.com/apache/flink/pull/12204#issuecomment-629847515
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "097ac2b06f10900c435115c24e699c5328ee3227",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1649",
"triggerID" : "097ac2b06f10900c435115c24e699c5328ee3227",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 097ac2b06f10900c435115c24e699c5328ee3227 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1649)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12204: [FLINK-17777][tests] Set HADOOP_CLASSPATH for Mesos TaskManagers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12204:
URL: https://github.com/apache/flink/pull/12204#issuecomment-629847515
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "097ac2b06f10900c435115c24e699c5328ee3227",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1649",
"triggerID" : "097ac2b06f10900c435115c24e699c5328ee3227",
"triggerType" : "PUSH"
}, {
"hash" : "1b0f95eb45256569484cff22599d080d968841f0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1b0f95eb45256569484cff22599d080d968841f0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 097ac2b06f10900c435115c24e699c5328ee3227 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1649)
* 1b0f95eb45256569484cff22599d080d968841f0 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12204: [FLINK-17777][tests] Set HADOOP_CLASSPATH for Mesos TaskManagers
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12204:
URL: https://github.com/apache/flink/pull/12204#issuecomment-629845444
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 6164354f0d56c46e06ea3f7bde52b6f3861bb7a5 (Sun May 17 19:07:57 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12204: [FLINK-17777][tests] Set HADOOP_CLASSPATH for Mesos TaskManagers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12204:
URL: https://github.com/apache/flink/pull/12204#issuecomment-629847515
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "097ac2b06f10900c435115c24e699c5328ee3227",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1649",
"triggerID" : "097ac2b06f10900c435115c24e699c5328ee3227",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 097ac2b06f10900c435115c24e699c5328ee3227 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1649)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] GJL commented on pull request #12204: [FLINK-17777][tests] Set HADOOP_CLASSPATH for Mesos TaskManagers
Posted by GitBox <gi...@apache.org>.
GJL commented on pull request #12204:
URL: https://github.com/apache/flink/pull/12204#issuecomment-630066941
I have to revert the `hotfix` commit. In standalone this happens
```
Trying to start actor system, external address 127.0.0.1:0, bind address 0.0.0.0:0.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12204: [FLINK-17777][tests] Set HADOOP_CLASSPATH for Mesos TaskManagers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12204:
URL: https://github.com/apache/flink/pull/12204#issuecomment-629847515
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "097ac2b06f10900c435115c24e699c5328ee3227",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1649",
"triggerID" : "097ac2b06f10900c435115c24e699c5328ee3227",
"triggerType" : "PUSH"
}, {
"hash" : "1b0f95eb45256569484cff22599d080d968841f0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1704",
"triggerID" : "1b0f95eb45256569484cff22599d080d968841f0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 097ac2b06f10900c435115c24e699c5328ee3227 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1649)
* 1b0f95eb45256569484cff22599d080d968841f0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1704)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] GJL commented on a change in pull request #12204: [FLINK-17777][tests] Set HADOOP_CLASSPATH for Mesos TaskManagers
Posted by GitBox <gi...@apache.org>.
GJL commented on a change in pull request #12204:
URL: https://github.com/apache/flink/pull/12204#discussion_r426424405
##########
File path: flink-jepsen/src/jepsen/flink/db.clj
##########
@@ -327,9 +327,14 @@
:delay 4000)]
(info "Submitted Flink Application via Marathon" marathon-response))))
+(defn- flink-mesos-configuration!
+ []
+ {:containerized.taskmanager.env.HADOOP_CLASSPATH (hadoop/hadoop-classpath!)})
Review comment:
Actually, an easier fix would be to add
```
"-Dcontainerized.taskmanager.env.HADOOP_CLASSPATH=$(/opt/hadoop/bin/hadoop classpath)"
```
to the mesos app master command.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] GJL edited a comment on pull request #12204: [FLINK-17777][tests] Set HADOOP_CLASSPATH for Mesos TaskManagers
Posted by GitBox <gi...@apache.org>.
GJL edited a comment on pull request #12204:
URL: https://github.com/apache/flink/pull/12204#issuecomment-630066941
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12204: [FLINK-17777][tests] Set HADOOP_CLASSPATH for Mesos TaskManagers
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12204:
URL: https://github.com/apache/flink/pull/12204#issuecomment-629847515
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "097ac2b06f10900c435115c24e699c5328ee3227",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "097ac2b06f10900c435115c24e699c5328ee3227",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 097ac2b06f10900c435115c24e699c5328ee3227 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org