You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by da...@apache.org on 2014/11/10 14:48:50 UTC
git commit: updated refs/heads/hotfix/CID-1251369 to 2e1550a
Repository: cloudstack
Updated Branches:
refs/heads/hotfix/CID-1251369 [created] 2e1550a10
CID 1251369: unintended not-null check changed to null check
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/2e1550a1
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/2e1550a1
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/2e1550a1
Branch: refs/heads/hotfix/CID-1251369
Commit: 2e1550a10c43093f8d077a7a88c03568b31fb4b1
Parents: 97fa4a0
Author: Daan Hoogland <dh...@schubergphilis.com>
Authored: Mon Nov 10 14:48:09 2014 +0100
Committer: Daan Hoogland <da...@onecht.net>
Committed: Mon Nov 10 14:48:09 2014 +0100
----------------------------------------------------------------------
server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/2e1550a1/server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java
----------------------------------------------------------------------
diff --git a/server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java b/server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java
index 10449e3..bcb2242 100755
--- a/server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java
+++ b/server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java
@@ -314,7 +314,7 @@ public class SnapshotManagerImpl extends ManagerBase implements SnapshotManager,
_accountMgr.checkAccess(CallContext.current().getCallingAccount(), null, true, volume);
SnapshotInfo snapshot = snapshotFactory.getSnapshot(snapshotId, DataStoreRole.Primary);
- if(snapshot != null)
+ if(snapshot == null)
{
s_logger.debug("Failed to create snapshot");
throw new CloudRuntimeException("Failed to create snapshot");