[GitHub] conglei commented on a change in pull request #5630: [bubble] Fixing ad-hoc metric labels

[GitBox <gi...@apache.org>]

conglei commented on a change in pull request #5630: [bubble] Fixing ad-hoc metric labels
URL: https://github.com/apache/incubator-superset/pull/5630#discussion_r210103310
 
 

 ##########
 File path: superset/assets/src/visualizations/nvd3_vis.js
 ##########
 @@ -329,9 +329,9 @@ export default function nvd3Vis(slice, payload) {
             `<tr><td style="color: ${p.color};">` +
               `<strong>${p[fd.entity]}</strong> (${p.group})` +
             '</td></tr>');
-          s += row(fd.x, formatter(p.x));
-          s += row(fd.y, formatter(p.y));
-          s += row(fd.size, formatter(p.size));
+          s += row(fd.x.label, formatter(p.x));
 
 Review comment:
   What about non ad-hoc metric field? seems like we should first test if fd.x is an object or it is just a string. Same thing for the other two. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org