[GitHub] [incubator-celeborn] AngersZhuuuu commented on a diff in pull request #1209: [CELEBORN-275] WrappedCallback should only handle response from replica

["AngersZhuuuu (via GitHub)" <gi...@apache.org>]

AngersZhuuuu commented on code in PR #1209:
URL: https://github.com/apache/incubator-celeborn/pull/1209#discussion_r1098411378


##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/PushDataHandler.scala:
##########
@@ -645,6 +635,25 @@ class PushDataHandler extends BaseMessageHandler with Logging {
 
   override def checkRegistered(): Boolean = registered.get()
 
+  class WrappedTimeMetric(

Review Comment:
   This class name is weird.... how about `RpcResponseCallbackWithTimer `



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org