You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@sedona.apache.org by "paleolimbot (via GitHub)" <gi...@apache.org> on 2025/09/22 15:33:33 UTC
[I] rust: Eliminate dependency on forked geo-index crate [sedona-db]
paleolimbot opened a new issue, #124:
URL: https://github.com/apache/sedona-db/issues/124
We use the geo-index crate ( https://github.com/kylebarron/geo-index ) heavily in sedona-spatial join. In the lead up to the release, we discovered a few features that we needed to iterate on in conjunction with our at the time not-yet-public code ( https://github.com/wherobots/geo-index ). Now that we have a release, we should upstream the required changes or expose hooks in geo-index such that we can separate the code we need for the KNN join with released geo-index!
Note that many of the changes in the fork have already been upstreamed but I think the one involving spherical distance hasn't quite made it there yet.
cc @zhangfengcdt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] rust: Eliminate dependency on forked geo-index crate [sedona-db]
Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu commented on issue #124:
URL: https://github.com/apache/sedona-db/issues/124#issuecomment-3342076572
Thanks. Let's get it done by 0.2.0. We will eliminate all forks in 0.2.0 and release to crates.io
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] rust: Eliminate dependency on forked geo-index crate [sedona-db]
Posted by "zhangfengcdt (via GitHub)" <gi...@apache.org>.
zhangfengcdt commented on issue #124:
URL: https://github.com/apache/sedona-db/issues/124#issuecomment-3341925566
> I agree with Kyle here: [kylebarron/geo-index#135](https://github.com/kylebarron/geo-index/pull/135)
>
> Why did we use heavy sphere distance calculation in place in geo-index?
>
> CC [@zhangfengcdt](https://github.com/zhangfengcdt) [@Kontinuation](https://github.com/Kontinuation)
@jiayuasu The PR Kyle created seems using old code from our geo-index fork. The latest one already uses the geo crate's distance calculation:
https://github.com/wherobots/geo-index/pull/5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] rust: Eliminate dependency on forked geo-index crate [sedona-db]
Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu commented on issue #124:
URL: https://github.com/apache/sedona-db/issues/124#issuecomment-3336736900
I agree with Kyle here: https://github.com/kylebarron/geo-index/pull/135
Why did we use heavy sphere distance calculation in place in geo-index?
CC @zhangfengcdt @Kontinuation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] rust: Eliminate dependency on forked geo-index crate [sedona-db]
Posted by "zhangfengcdt (via GitHub)" <gi...@apache.org>.
zhangfengcdt closed issue #124: rust: Eliminate dependency on forked geo-index crate
URL: https://github.com/apache/sedona-db/issues/124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] rust: Eliminate dependency on forked geo-index crate [sedona-db]
Posted by "Kontinuation (via GitHub)" <gi...@apache.org>.
Kontinuation commented on issue #124:
URL: https://github.com/apache/sedona-db/issues/124#issuecomment-3338198757
This is a valid concern. `geo` crate already has [Haversine](https://docs.rs/geo/latest/geo/algorithm/line_measures/metric_spaces/constant.Haversine.html) and [Geodesic](https://docs.rs/geo/latest/geo/algorithm/line_measures/metric_spaces/static.Geodesic.html) for point <-> point distance computation.
There's another patch required by sedona-db's KNN join: https://github.com/wherobots/geo-index/pull/5. I have also suggested defining DistanceMetric more flexibly for that patch: https://github.com/apache/sedona-db/pull/53#pullrequestreview-3208589822.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] rust: Eliminate dependency on forked geo-index crate [sedona-db]
Posted by "zhangfengcdt (via GitHub)" <gi...@apache.org>.
zhangfengcdt commented on issue #124:
URL: https://github.com/apache/sedona-db/issues/124#issuecomment-3341928127
> This is a valid concern. `geo` crate already has [Haversine](https://docs.rs/geo/latest/geo/algorithm/line_measures/metric_spaces/constant.Haversine.html) and [Geodesic](https://docs.rs/geo/latest/geo/algorithm/line_measures/metric_spaces/static.Geodesic.html) for point <-> point distance calculation.
>
> Sedona-db's KNN join requires yet another patch to be merged into upstream: [wherobots/geo-index#5](https://github.com/wherobots/geo-index/pull/5). I have also suggested defining DistanceMetric more flexibly for that patch: [#53 (review)](https://github.com/apache/sedona-db/pull/53#pullrequestreview-3208589822).
Our geo-index was already refactored to use the geo crate distance function.
w.r.t. the refactoring to neighbors_geometry to be indices based parameters, I will try to implement it (maybe coexist with the current geometries approach) before merging to upstream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org