You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@griffin.apache.org by "guoyuepeng (via GitHub)" <gi...@apache.org> on 2024/03/07 12:39:12 UTC
[PR] Griffin 1.0.0 [griffin]
guoyuepeng opened a new pull request, #646:
URL: https://github.com/apache/griffin/pull/646
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@griffin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Griffin 1.0.0 [griffin]
Posted by "toyboxman (via GitHub)" <gi...@apache.org>.
toyboxman commented on code in PR #646:
URL: https://github.com/apache/griffin/pull/646#discussion_r1559330157
##########
griffin-core/src/main/java/org/apache/griffin/core/worker/schedule/TaskDispatcherScheduler.java:
##########
@@ -0,0 +1,291 @@
+package org.apache.griffin.core.worker.schedule;
+
+import com.google.common.collect.Lists;
+import com.google.common.collect.Queues;
+import org.apache.commons.collections4.CollectionUtils;
+import org.apache.griffin.core.worker.context.WorkerContext;
+import org.apache.griffin.core.worker.entity.bo.DQInstance;
+import org.apache.griffin.core.worker.entity.bo.task.DQBaseTask;
+import org.apache.griffin.core.worker.entity.enums.DQInstanceStatus;
+import org.apache.griffin.core.worker.entity.enums.DQTaskStatus;
+import org.apache.griffin.core.worker.service.DQInstanceService;
+import org.apache.griffin.core.worker.service.DQTaskService;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.scheduling.annotation.Scheduled;
+import org.springframework.stereotype.Component;
+
+import javax.annotation.PostConstruct;
+import java.util.List;
+import java.util.Queue;
+import java.util.concurrent.LinkedBlockingQueue;
+import java.util.concurrent.TimeUnit;
+
+/**
+ * 任务执行调度期 和 dispatcher交互
Review Comment:
there're some comments using Chinese, we should translate them and align same style with other parts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@griffin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Griffin 1.0.0 [griffin]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #646: Griffin 1.0.0
URL: https://github.com/apache/griffin/pull/646
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@griffin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Griffin 1.0.0 [griffin]
Posted by "toyboxman (via GitHub)" <gi...@apache.org>.
toyboxman commented on code in PR #646:
URL: https://github.com/apache/griffin/pull/646#discussion_r1559337741
##########
pom.xml:
##########
@@ -97,22 +112,61 @@ under the License.
<modules>
- <module>ui</module>
- <module>service</module>
- <module>measure</module>
+ <module>griffin-bom</module>
+ <module>griffin-common</module>
+ <module>griffin-core</module>
+ <module>griffin-scheduler</module>
+ <module>griffin-anomalydetection</module>
</modules>
<dependencyManagement>
<dependencies>
<dependency>
- <groupId>junit</groupId>
- <artifactId>junit</artifactId>
- <version>4.12</version>
- <scope>test</scope>
+ <groupId>org.springframework.boot</groupId>
+ <artifactId>spring-boot-dependencies</artifactId>
+ <version>${spring-boot.version}</version>
+ <type>pom</type>
+ <scope>import</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.testcontainers</groupId>
+ <artifactId>testcontainers-bom</artifactId>
+ <version>${testcontainers.version}</version>
+ <type>pom</type>
+ <scope>import</scope>
</dependency>
</dependencies>
</dependencyManagement>
+ <dependencies>
+ <dependency>
+ <groupId>org.springframework.boot</groupId>
+ <artifactId>spring-boot-starter-logging</artifactId>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>org.projectlombok</groupId>
+ <artifactId>lombok</artifactId>
+ <scope>provided</scope>
+ </dependency>
+ <!-- Test dependencies -->
+ <dependency>
+ <groupId>org.springframework.boot</groupId>
+ <artifactId>spring-boot-starter-test</artifactId>
+ <scope>test</scope>
+ </dependency>
+<!-- <dependency>-->
Review Comment:
remove the unused definition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@griffin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Griffin 1.0.0 [griffin]
Posted by "guoyuepeng (via GitHub)" <gi...@apache.org>.
guoyuepeng commented on code in PR #646:
URL: https://github.com/apache/griffin/pull/646#discussion_r1560488136
##########
pom.xml:
##########
@@ -97,22 +112,61 @@ under the License.
<modules>
- <module>ui</module>
- <module>service</module>
- <module>measure</module>
+ <module>griffin-bom</module>
+ <module>griffin-common</module>
+ <module>griffin-core</module>
+ <module>griffin-scheduler</module>
+ <module>griffin-anomalydetection</module>
</modules>
<dependencyManagement>
<dependencies>
<dependency>
- <groupId>junit</groupId>
- <artifactId>junit</artifactId>
- <version>4.12</version>
- <scope>test</scope>
+ <groupId>org.springframework.boot</groupId>
+ <artifactId>spring-boot-dependencies</artifactId>
+ <version>${spring-boot.version}</version>
+ <type>pom</type>
+ <scope>import</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.testcontainers</groupId>
+ <artifactId>testcontainers-bom</artifactId>
+ <version>${testcontainers.version}</version>
+ <type>pom</type>
+ <scope>import</scope>
</dependency>
</dependencies>
</dependencyManagement>
+ <dependencies>
+ <dependency>
+ <groupId>org.springframework.boot</groupId>
+ <artifactId>spring-boot-starter-logging</artifactId>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>org.projectlombok</groupId>
+ <artifactId>lombok</artifactId>
+ <scope>provided</scope>
+ </dependency>
+ <!-- Test dependencies -->
+ <dependency>
+ <groupId>org.springframework.boot</groupId>
+ <artifactId>spring-boot-starter-test</artifactId>
+ <scope>test</scope>
+ </dependency>
+<!-- <dependency>-->
Review Comment:
add it here for later usage.
##########
pom.xml:
##########
@@ -97,22 +112,61 @@ under the License.
<modules>
- <module>ui</module>
- <module>service</module>
- <module>measure</module>
+ <module>griffin-bom</module>
+ <module>griffin-common</module>
+ <module>griffin-core</module>
+ <module>griffin-scheduler</module>
+ <module>griffin-anomalydetection</module>
</modules>
<dependencyManagement>
<dependencies>
<dependency>
- <groupId>junit</groupId>
- <artifactId>junit</artifactId>
- <version>4.12</version>
- <scope>test</scope>
+ <groupId>org.springframework.boot</groupId>
+ <artifactId>spring-boot-dependencies</artifactId>
+ <version>${spring-boot.version}</version>
+ <type>pom</type>
+ <scope>import</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.testcontainers</groupId>
+ <artifactId>testcontainers-bom</artifactId>
+ <version>${testcontainers.version}</version>
+ <type>pom</type>
+ <scope>import</scope>
</dependency>
</dependencies>
</dependencyManagement>
+ <dependencies>
+ <dependency>
+ <groupId>org.springframework.boot</groupId>
+ <artifactId>spring-boot-starter-logging</artifactId>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>org.projectlombok</groupId>
+ <artifactId>lombok</artifactId>
+ <scope>provided</scope>
+ </dependency>
+ <!-- Test dependencies -->
+ <dependency>
+ <groupId>org.springframework.boot</groupId>
+ <artifactId>spring-boot-starter-test</artifactId>
+ <scope>test</scope>
+ </dependency>
+<!-- <dependency>-->
Review Comment:
add it here for later usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@griffin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Griffin 1.0.0 [griffin]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #646:
URL: https://github.com/apache/griffin/pull/646#issuecomment-2125966330
Automated Message: This PR is being labelled as stale and will be closed in next 15 days due to lack of activity. To avoid this push new commits or ask the committers for a review/ resolution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@griffin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Griffin 1.0.0 [griffin]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #646:
URL: https://github.com/apache/griffin/pull/646#issuecomment-2041239268
Automated Message: This PR is being labelled as stale and will be closed in next 15 days due to lack of activity. To avoid this push new commits or ask the committers for a review/ resolution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@griffin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Griffin 1.0.0 [griffin]
Posted by "toyboxman (via GitHub)" <gi...@apache.org>.
toyboxman commented on code in PR #646:
URL: https://github.com/apache/griffin/pull/646#discussion_r1559621236
##########
griffin-anomalydetection/pom.xml:
##########
@@ -0,0 +1,41 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.apache.griffin</groupId>
+ <artifactId>griffin-parent</artifactId>
+ <version>${revision}</version>
+ <relativePath>../pom.xml</relativePath>
+ </parent>
+
+ <artifactId>griffin-anomalydetection</artifactId>
Review Comment:
anomalydetection looks a bit long name, coud you find a simple name for it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@griffin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Griffin 1.0.0 [griffin]
Posted by "toyboxman (via GitHub)" <gi...@apache.org>.
toyboxman commented on PR #646:
URL: https://github.com/apache/griffin/pull/646#issuecomment-2051682573
LGTM.
Let's merge ASAP, then all paticipants of the commnity can continue to contribute and bring out the new grffin.
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@griffin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Griffin 1.0.0 [griffin]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #646:
URL: https://github.com/apache/griffin/pull/646#issuecomment-2155709791
Automated Message: We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the 'no-pr-activity' tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@griffin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Griffin 1.0.0 [griffin]
Posted by "toyboxman (via GitHub)" <gi...@apache.org>.
toyboxman commented on PR #646:
URL: https://github.com/apache/griffin/pull/646#issuecomment-2069622015
Hello, @guoyuepeng
Could you merge this, let's start with latest basis.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@griffin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Griffin 1.0.0 [griffin]
Posted by "guoyuepeng (via GitHub)" <gi...@apache.org>.
guoyuepeng commented on PR #646:
URL: https://github.com/apache/griffin/pull/646#issuecomment-2049281885
we need to refactor our scheduler so that we might leverage customer's existing scheduler engines.
most of time, most customer maintain one scheduler engine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@griffin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Griffin 1.0.0 [griffin]
Posted by "guoyuepeng (via GitHub)" <gi...@apache.org>.
guoyuepeng commented on PR #646:
URL: https://github.com/apache/griffin/pull/646#issuecomment-2050884672
existing trigger are usually like
public interface Trigger {
@Nullable
Date nextExecutionTime(TriggerContext triggerContext);
}
but we need something like
Trigger with CitiesDimension with SeasonDimension
those cities are dynamically injected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@griffin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Griffin 1.0.0 [griffin]
Posted by "guoyuepeng (via GitHub)" <gi...@apache.org>.
guoyuepeng commented on PR #646:
URL: https://github.com/apache/griffin/pull/646#issuecomment-2054409097
> LGTM.
>
> Let's merge ASAP, then all paticipants of the commnity can continue to contribute and bring out the new grffin.
>
> Thanks
a long way to go, let's make it faster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@griffin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org