You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/06/12 15:31:00 UTC
[jira] [Commented] (FLINK-9572) Extend InternalAppendingState with
internal stored state access
[ https://issues.apache.org/jira/browse/FLINK-9572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16509752#comment-16509752 ]
ASF GitHub Bot commented on FLINK-9572:
---------------------------------------
GitHub user azagrebin opened a pull request:
https://github.com/apache/flink/pull/6156
[FLINK-9572] Extend InternalAppendingState with internal stored state access
## What is the purpose of the change
Extend InternalAppendingState with get and update methods for internal stored state.
Implement them in concrete states in backends.
## Brief change log
- *InternalAppendingState* has now methods *getInternal* and *updateInternal*
- Heap and Rocksdb merging states implement the methods
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
It should be covered by existing tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (yes)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/azagrebin/flink FLINK-9572
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6156.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6156
----
commit f235b327d7db370b6e4457ecc863cbf2626b4488
Author: Andrey Zagrebin <az...@...>
Date: 2018-06-12T15:24:20Z
[FLINK-9572] Extend InternalAppendingState with internal stored state access
----
> Extend InternalAppendingState with internal stored state access
> ---------------------------------------------------------------
>
> Key: FLINK-9572
> URL: https://issues.apache.org/jira/browse/FLINK-9572
> Project: Flink
> Issue Type: Sub-task
> Components: State Backends, Checkpointing
> Affects Versions: 1.6.0
> Reporter: Andrey Zagrebin
> Assignee: Andrey Zagrebin
> Priority: Major
> Fix For: 1.6.0
>
>
>
> {code:java}
> public interface InternalAppendingState<K, N, IN, SV, OUT> ... {
> SV getInternal();
> void updateInternal(SV);
> }
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)