You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by "Jakob Homan (Created) (JIRA)" <ji...@apache.org> on 2012/04/07 22:40:15 UTC

[jira] [Created] (GIRAPH-177) SimplePageRankVertex has two redundant casts

SimplePageRankVertex has two redundant casts
--------------------------------------------

                 Key: GIRAPH-177
                 URL: https://issues.apache.org/jira/browse/GIRAPH-177
             Project: Giraph
          Issue Type: Improvement
            Reporter: Jakob Homan
            Priority: Trivial


{code}        DoubleWritable maxPagerank =
            (DoubleWritable) maxAggreg.getAggregatedValue();
        LOG.info("aggregatedMaxPageRank=" + maxPagerank.get());
        DoubleWritable minPagerank =
            (DoubleWritable) minAggreg.getAggregatedValue();
        LOG.info("aggregatedMinPageRank=" + minPagerank.get());{code}
Both MinAggregator and MaxAggregator are already parameterized on DoubleWritable, so it's not necessary to cast their functions' results.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (GIRAPH-177) SimplePageRankVertex has two redundant casts

Posted by "Devaraj K (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GIRAPH-177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Devaraj K updated GIRAPH-177:
-----------------------------

    Attachment: GIRAPH-177.patch
    
> SimplePageRankVertex has two redundant casts
> --------------------------------------------
>
>                 Key: GIRAPH-177
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-177
>             Project: Giraph
>          Issue Type: Improvement
>    Affects Versions: 0.2.0
>            Reporter: Jakob Homan
>            Priority: Trivial
>              Labels: newbie
>         Attachments: GIRAPH-177.patch
>
>
> {code}        DoubleWritable maxPagerank =
>             (DoubleWritable) maxAggreg.getAggregatedValue();
>         LOG.info("aggregatedMaxPageRank=" + maxPagerank.get());
>         DoubleWritable minPagerank =
>             (DoubleWritable) minAggreg.getAggregatedValue();
>         LOG.info("aggregatedMinPageRank=" + minPagerank.get());{code}
> Both MinAggregator and MaxAggregator are already parameterized on DoubleWritable, so it's not necessary to cast their functions' results.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (GIRAPH-177) SimplePageRankVertex has two redundant casts

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GIRAPH-177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251941#comment-13251941 ] 

Hudson commented on GIRAPH-177:
-------------------------------

Integrated in Giraph-trunk-Commit #101 (See [https://builds.apache.org/job/Giraph-trunk-Commit/101/])
    GIRAPH-177: SimplePageRankVertex has two redundant casts. Contributed by Devaraj K. (Revision 1324988)

     Result = SUCCESS
jghoman : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1324988
Files : 
* /incubator/giraph/trunk/CHANGELOG
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimplePageRankVertex.java

                
> SimplePageRankVertex has two redundant casts
> --------------------------------------------
>
>                 Key: GIRAPH-177
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-177
>             Project: Giraph
>          Issue Type: Improvement
>    Affects Versions: 0.2.0
>            Reporter: Jakob Homan
>            Assignee: Devaraj K
>            Priority: Trivial
>              Labels: newbie
>             Fix For: 0.2.0
>
>         Attachments: GIRAPH-177.patch
>
>
> {code}        DoubleWritable maxPagerank =
>             (DoubleWritable) maxAggreg.getAggregatedValue();
>         LOG.info("aggregatedMaxPageRank=" + maxPagerank.get());
>         DoubleWritable minPagerank =
>             (DoubleWritable) minAggreg.getAggregatedValue();
>         LOG.info("aggregatedMinPageRank=" + minPagerank.get());{code}
> Both MinAggregator and MaxAggregator are already parameterized on DoubleWritable, so it's not necessary to cast their functions' results.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira