[jira] [Commented] (TEZ-1836) Provide better error messages when tez.runtime.io.sort.mb is wrongly configured

["Hitesh Shah (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-1836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14244856#comment-14244856 ] 

Hitesh Shah commented on TEZ-1836:
----------------------------------

[~sseth] Mind taking a look? I have a question on what should be our check. Earlier, there were redundant checks on both the assignedMemory as well as the configured memory. My understanding is that it should likely be safe to check only the initial configured memory ( the assumption being that if there is enough memory in the JVM, the assigned value will be the same as the configured one in both single and multiple sorter scenarios ).

[~vasanthkumar] Thanks for the patch. An additional minor nit to be addressed - the exception thrown for TezRuntimeConfiguration.TEZ_RUNTIME_SORT_SPILL_PERCENT needs a similar clarification fix.

 

> Provide better error messages when tez.runtime.io.sort.mb is wrongly configured
> -------------------------------------------------------------------------------
>
>                 Key: TEZ-1836
>                 URL: https://issues.apache.org/jira/browse/TEZ-1836
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Rajesh Balamohan
>            Assignee: Vasanth kumar RJ
>         Attachments: TEZ-1836.1.patch
>
>
> For tez.runtime.io.sort.mb=3000, following error message is thrown
> >>>
> info=[Error: Failure while running task:java.lang.RuntimeException: java.io.IOException: Invalid "tez.runtime.io.sort.mb": 3000
> >>>
> This should mention the range of valid configuration for "tez.runtime.io.sort.mb" (1 to 2047)
> For tez.runtime.io.sort.mb=0, following error message is thrown
> >>>>
> info=[Error: Failure while running task:java.lang.IllegalArgumentException: io.sort.mb should be larger than 0
>         at com.google.common.base.Preconditions.checkArgument(Preconditions.java:88)
>         at org.apache.tez.runtime.library.common.sort.impl.ExternalSorter.getInitialMemoryRequirement(ExternalSorter.java:289)
> >>>>
> This should mention "tez.runtime.io.sort.mb" and not "io.sort.mb".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)