You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org> on 2021/06/15 07:41:50 UTC
[Impala-ASF-CR] IMPALA-10742: Fix DCHECK in CreateColIdx2EqConjunctMap
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17596
Change subject: IMPALA-10742: Fix DCHECK in CreateColIdx2EqConjunctMap
......................................................................
IMPALA-10742: Fix DCHECK in CreateColIdx2EqConjunctMap
The following query was hitting a DCHECK because the right side was not
a literal (due to disabling expression rewrite).
SET enable_expr_rewrites=0;
select count(*) from alltypesagg where timestamp_col
between cast('2010-01-01 00:00:00' as timestamp)
and cast('2010-01-01 01:40:00' as timestamp);
The fix is to ignore these predicates instead of DCHECKing.
Testing:
- Changed TestExprs to use Parquet instead of Text in core tests.
Parquet seems more interesting as it also gives coverage for
predicate pushdown logic. The coverage of exhaustive tests is
not changed.
- Ran TestExprs.
Change-Id: I1ef97d829e6c3792aade9c61c4aee0d91cd0064b
---
M be/src/exec/parquet/hdfs-parquet-scanner.cc
M tests/query_test/test_exprs.py
2 files changed, 7 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/17596/2
--
To view, visit http://gerrit.cloudera.org:8080/17596
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1ef97d829e6c3792aade9c61c4aee0d91cd0064b
Gerrit-Change-Number: 17596
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
[Impala-ASF-CR] IMPALA-10742: Fix DCHECK in CreateColIdx2EqConjunctMap
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17596 )
Change subject: IMPALA-10742: Fix DCHECK in CreateColIdx2EqConjunctMap
......................................................................
Patch Set 4:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/17596/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/17596/3//COMMIT_MSG@9
PS3, Line 9: the right side was not
> nit: could you elaborate a little?
Done
http://gerrit.cloudera.org:8080/#/c/17596/3/be/src/exec/parquet/hdfs-parquet-scanner.cc
File be/src/exec/parquet/hdfs-parquet-scanner.cc:
http://gerrit.cloudera.org:8080/#/c/17596/3/be/src/exec/parquet/hdfs-parquet-scanner.cc@1663
PS3, Line 1663: ==
> Shouldn't it be ==?
ouch, thanks ...
http://gerrit.cloudera.org:8080/#/c/17596/3/tests/query_test/test_exprs.py
File tests/query_test/test_exprs.py:
http://gerrit.cloudera.org:8080/#/c/17596/3/tests/query_test/test_exprs.py@42
PS3, Line 42:
> nit: no need for \
Done
--
To view, visit http://gerrit.cloudera.org:8080/17596
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ef97d829e6c3792aade9c61c4aee0d91cd0064b
Gerrit-Change-Number: 17596
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Jun 2021 12:58:30 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10742: Fix DCHECK in CreateColIdx2EqConjunctMap
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17596 )
Change subject: IMPALA-10742: Fix DCHECK in CreateColIdx2EqConjunctMap
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8917/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17596
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ef97d829e6c3792aade9c61c4aee0d91cd0064b
Gerrit-Change-Number: 17596
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Jun 2021 08:07:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10742: Fix DCHECK in CreateColIdx2EqConjunctMap
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17596 )
Change subject: IMPALA-10742: Fix DCHECK in CreateColIdx2EqConjunctMap
......................................................................
IMPALA-10742: Fix DCHECK in CreateColIdx2EqConjunctMap
The following query was hitting a DCHECK because the right side was not
a literal (due to disabling expression rewrite):
set enable_expr_rewrites=0;
select count(*) from alltypesagg where timestamp_col
between cast('2010-01-01 00:00:00' as timestamp)
and cast('2010-01-01 01:40:00' as timestamp);
An even simpler problematic query:
select count(*) from alltypestiny where int_col = 1 + 1;
The cause of the issue was that FE expects the right side
to be constant expr to generate a stat predicate, but it does not
need to be a literal, while the BE expected a literal. By default
constant folding converts all constant expressions to literals, so
this only matters if expression rewrites are turned off.
The fix is to ignore these predicates instead of DCHECKing. It would be
possible to evaluate const expr in BE instead of needing a literal,
but this would add complexity and only help in a non default case that
is not used normally in production.
I think that the best solution would be to pass exact values instead of
expressions from FE to BE for stat filtering, but this would be a
bigger change.
Testing:
- Changed TestExprs to use Parquet instead of Text in core tests.
Parquet seems more interesting as it also gives coverage for
predicate pushdown logic. The coverage of exhaustive tests is
not changed.
- Ran TestExprs.
Change-Id: I1ef97d829e6c3792aade9c61c4aee0d91cd0064b
Reviewed-on: http://gerrit.cloudera.org:8080/17596
Reviewed-by: Csaba Ringhofer <cs...@cloudera.com>
Tested-by: Csaba Ringhofer <cs...@cloudera.com>
---
M be/src/exec/parquet/hdfs-parquet-scanner.cc
M tests/query_test/test_exprs.py
2 files changed, 8 insertions(+), 6 deletions(-)
Approvals:
Csaba Ringhofer: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/17596
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1ef97d829e6c3792aade9c61c4aee0d91cd0064b
Gerrit-Change-Number: 17596
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-10742: Fix DCHECK in CreateColIdx2EqConjunctMap
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17596 )
Change subject: IMPALA-10742: Fix DCHECK in CreateColIdx2EqConjunctMap
......................................................................
Patch Set 4: Code-Review+2
Thanks for fixing the issues, LGTM!
--
To view, visit http://gerrit.cloudera.org:8080/17596
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ef97d829e6c3792aade9c61c4aee0d91cd0064b
Gerrit-Change-Number: 17596
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Jun 2021 13:21:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10742: Fix DCHECK in CreateColIdx2EqConjunctMap
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Daniel Becker, Zoltan Borok-Nagy, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17596
to look at the new patch set (#4).
Change subject: IMPALA-10742: Fix DCHECK in CreateColIdx2EqConjunctMap
......................................................................
IMPALA-10742: Fix DCHECK in CreateColIdx2EqConjunctMap
The following query was hitting a DCHECK because the right side was not
a literal (due to disabling expression rewrite):
set enable_expr_rewrites=0;
select count(*) from alltypesagg where timestamp_col
between cast('2010-01-01 00:00:00' as timestamp)
and cast('2010-01-01 01:40:00' as timestamp);
An even simpler problematic query:
select count(*) from alltypestiny where int_col = 1 + 1;
The cause of the issue was that FE expects the right side
to be constant expr to generate a stat predicate, but it does not
need to be a literal, while the BE expected a literal. By default
constant folding converts all constant expressions to literals, so
this only matters if expression rewrites are turned off.
The fix is to ignore these predicates instead of DCHECKing. It would be
possible to evaluate const expr in BE instead of needing a literal,
but this would add complexity and only help in a non default case that
is not used normally in production.
I think that the best solution would be to pass exact values instead of
expressions from FE to BE for stat filtering, but this would be a
bigger change.
Testing:
- Changed TestExprs to use Parquet instead of Text in core tests.
Parquet seems more interesting as it also gives coverage for
predicate pushdown logic. The coverage of exhaustive tests is
not changed.
- Ran TestExprs.
Change-Id: I1ef97d829e6c3792aade9c61c4aee0d91cd0064b
---
M be/src/exec/parquet/hdfs-parquet-scanner.cc
M tests/query_test/test_exprs.py
2 files changed, 8 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/17596/4
--
To view, visit http://gerrit.cloudera.org:8080/17596
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1ef97d829e6c3792aade9c61c4aee0d91cd0064b
Gerrit-Change-Number: 17596
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-10742: Fix DCHECK in CreateColIdx2EqConjunctMap
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17596 )
Change subject: IMPALA-10742: Fix DCHECK in CreateColIdx2EqConjunctMap
......................................................................
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/17596/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/17596/3//COMMIT_MSG@9
PS3, Line 9: the right side was not
nit: could you elaborate a little?
http://gerrit.cloudera.org:8080/#/c/17596/3/be/src/exec/parquet/hdfs-parquet-scanner.cc
File be/src/exec/parquet/hdfs-parquet-scanner.cc:
http://gerrit.cloudera.org:8080/#/c/17596/3/be/src/exec/parquet/hdfs-parquet-scanner.cc@1663
PS3, Line 1663: !=
Shouldn't it be ==?
http://gerrit.cloudera.org:8080/#/c/17596/3/tests/query_test/test_exprs.py
File tests/query_test/test_exprs.py:
http://gerrit.cloudera.org:8080/#/c/17596/3/tests/query_test/test_exprs.py@42
PS3, Line 42: \
nit: no need for \
--
To view, visit http://gerrit.cloudera.org:8080/17596
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ef97d829e6c3792aade9c61c4aee0d91cd0064b
Gerrit-Change-Number: 17596
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Jun 2021 09:39:49 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10742: Fix DCHECK in CreateColIdx2EqConjunctMap
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17596 )
Change subject: IMPALA-10742: Fix DCHECK in CreateColIdx2EqConjunctMap
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17596/2/tests/query_test/test_exprs.py
File tests/query_test/test_exprs.py:
http://gerrit.cloudera.org:8080/#/c/17596/2/tests/query_test/test_exprs.py@43
PS2, Line 43: \
flake8: E502 the backslash is redundant between brackets
--
To view, visit http://gerrit.cloudera.org:8080/17596
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ef97d829e6c3792aade9c61c4aee0d91cd0064b
Gerrit-Change-Number: 17596
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Jun 2021 07:42:34 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10742: Fix DCHECK in CreateColIdx2EqConjunctMap
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17596 )
Change subject: IMPALA-10742: Fix DCHECK in CreateColIdx2EqConjunctMap
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8920/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17596
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ef97d829e6c3792aade9c61c4aee0d91cd0064b
Gerrit-Change-Number: 17596
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Jun 2021 13:19:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10742: Fix DCHECK in CreateColIdx2EqConjunctMap
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Daniel Becker, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17596
to look at the new patch set (#3).
Change subject: IMPALA-10742: Fix DCHECK in CreateColIdx2EqConjunctMap
......................................................................
IMPALA-10742: Fix DCHECK in CreateColIdx2EqConjunctMap
The following query was hitting a DCHECK because the right side was not
a literal (due to disabling expression rewrite).
SET enable_expr_rewrites=0;
select count(*) from alltypesagg where timestamp_col
between cast('2010-01-01 00:00:00' as timestamp)
and cast('2010-01-01 01:40:00' as timestamp);
The fix is to ignore these predicates instead of DCHECKing.
Testing:
- Changed TestExprs to use Parquet instead of Text in core tests.
Parquet seems more interesting as it also gives coverage for
predicate pushdown logic. The coverage of exhaustive tests is
not changed.
- Ran TestExprs.
Change-Id: I1ef97d829e6c3792aade9c61c4aee0d91cd0064b
---
M be/src/exec/parquet/hdfs-parquet-scanner.cc
M tests/query_test/test_exprs.py
2 files changed, 7 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/17596/3
--
To view, visit http://gerrit.cloudera.org:8080/17596
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1ef97d829e6c3792aade9c61c4aee0d91cd0064b
Gerrit-Change-Number: 17596
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-10742: Fix DCHECK in CreateColIdx2EqConjunctMap
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17596 )
Change subject: IMPALA-10742: Fix DCHECK in CreateColIdx2EqConjunctMap
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8916/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17596
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ef97d829e6c3792aade9c61c4aee0d91cd0064b
Gerrit-Change-Number: 17596
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Jun 2021 08:03:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10742: Fix DCHECK in CreateColIdx2EqConjunctMap
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17596 )
Change subject: IMPALA-10742: Fix DCHECK in CreateColIdx2EqConjunctMap
......................................................................
Patch Set 4: Verified+1 Code-Review+2
The issue seems unrelated, I am merging this to unblock exhaustive runs.
--
To view, visit http://gerrit.cloudera.org:8080/17596
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ef97d829e6c3792aade9c61c4aee0d91cd0064b
Gerrit-Change-Number: 17596
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Jun 2021 08:40:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10742: Fix DCHECK in CreateColIdx2EqConjunctMap
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17596 )
Change subject: IMPALA-10742: Fix DCHECK in CreateColIdx2EqConjunctMap
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17596/2/tests/query_test/test_exprs.py
File tests/query_test/test_exprs.py:
http://gerrit.cloudera.org:8080/#/c/17596/2/tests/query_test/test_exprs.py@43
PS2, Line 43: \
> flake8: E502 the backslash is redundant between brackets
Done
--
To view, visit http://gerrit.cloudera.org:8080/17596
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ef97d829e6c3792aade9c61c4aee0d91cd0064b
Gerrit-Change-Number: 17596
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Jun 2021 07:45:31 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10742: Fix DCHECK in CreateColIdx2EqConjunctMap
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/17596 )
Change subject: IMPALA-10742: Fix DCHECK in CreateColIdx2EqConjunctMap
......................................................................
Patch Set 3: Code-Review+1
Thanks for fixing it.
--
To view, visit http://gerrit.cloudera.org:8080/17596
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ef97d829e6c3792aade9c61c4aee0d91cd0064b
Gerrit-Change-Number: 17596
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Jun 2021 09:13:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10742: Fix DCHECK in CreateColIdx2EqConjunctMap
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17596 )
Change subject: IMPALA-10742: Fix DCHECK in CreateColIdx2EqConjunctMap
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7227/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/17596
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ef97d829e6c3792aade9c61c4aee0d91cd0064b
Gerrit-Change-Number: 17596
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Jun 2021 07:46:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10742: Fix DCHECK in CreateColIdx2EqConjunctMap
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/17596 )
Change subject: IMPALA-10742: Fix DCHECK in CreateColIdx2EqConjunctMap
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/17596
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ef97d829e6c3792aade9c61c4aee0d91cd0064b
Gerrit-Change-Number: 17596
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Jun 2021 12:59:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10742: Fix DCHECK in CreateColIdx2EqConjunctMap
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17596 )
Change subject: IMPALA-10742: Fix DCHECK in CreateColIdx2EqConjunctMap
......................................................................
Patch Set 4: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7230/
--
To view, visit http://gerrit.cloudera.org:8080/17596
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ef97d829e6c3792aade9c61c4aee0d91cd0064b
Gerrit-Change-Number: 17596
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Jun 2021 19:24:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10742: Fix DCHECK in CreateColIdx2EqConjunctMap
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17596 )
Change subject: IMPALA-10742: Fix DCHECK in CreateColIdx2EqConjunctMap
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7230/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/17596
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ef97d829e6c3792aade9c61c4aee0d91cd0064b
Gerrit-Change-Number: 17596
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Jun 2021 13:22:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10742: Fix DCHECK in CreateColIdx2EqConjunctMap
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17596 )
Change subject: IMPALA-10742: Fix DCHECK in CreateColIdx2EqConjunctMap
......................................................................
Patch Set 5: Verified+1 Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17596
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ef97d829e6c3792aade9c61c4aee0d91cd0064b
Gerrit-Change-Number: 17596
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Jun 2021 08:41:09 +0000
Gerrit-HasComments: No