You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Eelco Hillenius (JIRA)" <ji...@apache.org> on 2007/06/25 01:55:26 UTC

[jira] Resolved: (WICKET-689) Please make it easier to use a custom RequestCycle

     [ https://issues.apache.org/jira/browse/WICKET-689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eelco Hillenius resolved WICKET-689.
------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.3.0-beta2

> Please make it easier to use a custom RequestCycle
> --------------------------------------------------
>
>                 Key: WICKET-689
>                 URL: https://issues.apache.org/jira/browse/WICKET-689
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.2.6
>         Environment: Java 5, Mac OS X 10.4.
>            Reporter: Willis Boyce
>            Assignee: Eelco Hillenius
>             Fix For: 1.3.0-beta2
>
>
> It's trival to introduce a new Session class.  Just override newSession in Application:
>     public Session newSession()
>     {
>         return new MySession(this);
>     }
> But introducing a new RequestCycle is a pain.  I have to override Session.getRequestCycleFactory or Application.getDefaultRequestCycleFactory, providing a new factory that returns the particular RequestCycle that I want.
> Strangely, there is a Session.newRequestCycle, but it's final.  (Why?)
> Suggestion:  Please make Session/RequestCycle work like Application/Session.  Let me just override newRequestCycle in Session and instantiate my RequestCycle.  Maybe Application should implement ISessionFactory, and Session should implement IRequestCycleFactory.  (Why does WebApplication implement ISessionFactory but not Application?)
>  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.