You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "slievrly (via GitHub)" <gi...@apache.org> on 2024/02/19 11:30:51 UTC
[PR] optimize: optimize serialization/deserialization of protocol codec [incubator-seata]
slievrly opened a new pull request, #6357:
URL: https://github.com/apache/incubator-seata/pull/6357
<!-- Please make sure you have read and understood the contributing guidelines -->
- [ ] I have registered the PR [changes](../changes).
### Ⅰ. Describe what this PR did
optimize serialization/deserialization of protocol codec
### Ⅱ. Does this pull request fix one issue?
<!-- If that, add "fixes #xxx" below in the next line, for example, fixes #97. -->
fixes #6267
### Ⅲ. Why don't you add test cases (unit test/integration test)?
### Ⅳ. Describe how to verify it
### Ⅴ. Special notes for reviews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: optimize serialization/deserialization of protocol codec [incubator-seata]
Posted by "slievrly (via GitHub)" <gi...@apache.org>.
slievrly merged PR #6357:
URL: https://github.com/apache/incubator-seata/pull/6357
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: optimize serialization/deserialization of protocol codec [incubator-seata]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6357:
URL: https://github.com/apache/incubator-seata/pull/6357#issuecomment-1953428381
## [Codecov](https://app.codecov.io/gh/apache/incubator-seata/pull/6357?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: `6 lines` in your changes are missing coverage. Please review.
> Comparison is base [(`b852a6c`)](https://app.codecov.io/gh/apache/incubator-seata/commit/b852a6cf20ef5cf2d027ea1ab1210fe11dbef1bf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 52.35% compared to head [(`1e9be90`)](https://app.codecov.io/gh/apache/incubator-seata/pull/6357?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 52.42%.
> :exclamation: Current head 1e9be90 differs from pull request most recent head 4d8925f. Consider uploading reports for the commit 4d8925f to get more accurate results
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/incubator-seata/pull/6357?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## 2.x #6357 +/- ##
============================================
+ Coverage 52.35% 52.42% +0.06%
- Complexity 5215 5221 +6
============================================
Files 920 920
Lines 31942 31936 -6
Branches 3815 3810 -5
============================================
+ Hits 16724 16741 +17
+ Misses 13570 13549 -21
+ Partials 1648 1646 -2
```
| [Files](https://app.codecov.io/gh/apache/incubator-seata/pull/6357?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../apache/seata/core/protocol/ProtocolConstants.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6357?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvY29yZS9wcm90b2NvbC9Qcm90b2NvbENvbnN0YW50cy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...che/seata/core/rpc/netty/v1/ProtocolV1Decoder.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6357?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvY29yZS9ycGMvbmV0dHkvdjEvUHJvdG9jb2xWMURlY29kZXIuamF2YQ==) | `61.81% <25.00%> (-3.64%)` | :arrow_down: |
| [...seata/core/serializer/SerializerServiceLoader.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6357?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvY29yZS9zZXJpYWxpemVyL1NlcmlhbGl6ZXJTZXJ2aWNlTG9hZGVyLmphdmE=) | `52.63% <76.92%> (+52.63%)` | :arrow_up: |
... and [4 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/6357/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org