You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/02/01 09:34:24 UTC

[GitHub] twalthr commented on issue #7626: [FLINK-11450][table] Port and move TableSource and TableSink to flink-table-common

twalthr commented on issue #7626: [FLINK-11450][table] Port and move TableSource and TableSink to flink-table-common
URL: https://github.com/apache/flink/pull/7626#issuecomment-459662198
 
 
   Thanks for the great work @dianfu. You ported a lot of classes. Maybe a bit too many. We talked about `TableDescriptor` but maybe there was some miscommunication. Not all subclasses of table descriptor must be ported at this point. Especially classes such as `Schema` has you have noticed need some rework. But we should finish the DDL discussion until we rework and break the API again.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services