[GitHub] [activemq-nms-amqp] Havret opened a new pull request #20: AMQNET-602: Set batchable flag to false for amqp transfer

[GitBox <gi...@apache.org>]

Havret opened a new pull request #20: AMQNET-602: Set batchable flag to false for amqp transfer
URL: https://github.com/apache/activemq-nms-amqp/pull/20
 
 
   This PR resolves the performance issue with brokers that respect the batchable flag for amqp transfer. https://github.com/apache/activemq-nms-amqp/pull/8#issuecomment-517366025
   
   It utilizes new Handel API of amqp net lite, and new testing toolkit, and thus we should wait with merge until https://github.com/Azure/amqpnetlite/commit/2c38af646de695c17ccccf6f6992fbeecd2a0252 is released and https://github.com/apache/activemq-nms-amqp/pull/9 is merged. 
   
   Moreover it illustrates the problem pointed out by @cjwmorgan-sol https://github.com/apache/activemq-nms-amqp/pull/9#issuecomment-521632602. Amqpnet lite sets settled flag to `true` for messages send in a fire and forget manner. **TestSendingMessageNonPersistentSetsBatchableFalse** is failing because of that. I think this issue should be addressed with higher precedence.
   
   Prerequisites:
   - [ ] amqpnetlite release,
   - [ ] test toolkit merge
   - [ ] settled issue solves for fire and forget sends
   - [ ] rebase and history cleanup 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services