[GitHub] [nifi] thenatog commented on a diff in pull request #6655: NIFI-10787 Cannot commit flows to nifi registry after updating our nifi release to 1.18.0

[GitBox <gi...@apache.org>]

thenatog commented on code in PR #6655:
URL: https://github.com/apache/nifi/pull/6655#discussion_r1022327567


##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/registry/flow/mapping/NiFiRegistryFlowMapper.java:
##########
@@ -193,7 +193,7 @@ public InstantiatedVersionedProcessGroup mapProcessGroup(final ProcessGroup grou
 
     // This is specific for the {@code NifiRegistryFlowRegistryClient}, purely for backward compatibility
     private String getRegistryUrl(final FlowRegistryClientNode registry) {
-        return registry.getComponentType().equals("org.apache.nifi.registry.flow.NifiRegistryFlowRegistryClient") ? registry.getRawPropertyValue(registry.getPropertyDescriptor("URL")) : "";
+        return registry.getComponentType().equals("org.apache.nifi.registry.flow.NifiRegistryFlowRegistryClient") ? registry.getRawPropertyValue(registry.getPropertyDescriptor("url")) : "";

Review Comment:
   Suggest adding a static final string variable to define this, eg `private static final String REGISTRY_URL_DESCRIPTOR_NAME = "url";`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org