You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2021/01/21 14:27:06 UTC

[GitHub] [drill] luocooong opened a new pull request #2150: DRILL-7827: Move the Pcapng format plugin to contrib folder

luocooong opened a new pull request #2150:
URL: https://github.com/apache/drill/pull/2150


   # [DRILL-7827](https://issues.apache.org/jira/browse/DRILL-7827): Move the Pcapng format plugin to contrib folder
   
   ## Description
   
   As a `contrib` module.
   
   ## Documentation
   There are no changes visible to the user.
   
   ## Testing
   Ran unit tests associated with the Image plugin.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] cgivre commented on pull request #2150: DRILL-7827: Move the Pcapng format plugin to contrib folder

Posted by GitBox <gi...@apache.org>.
cgivre commented on pull request #2150:
URL: https://github.com/apache/drill/pull/2150#issuecomment-769530518


   @luocooong The PR looks good but one of the unit tests was failing.  Can you please rebase to current master and confirm that unit tests pass before merging?  Thx


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] luocooong commented on pull request #2150: DRILL-7827: Move the Pcapng format plugin to contrib folder

Posted by GitBox <gi...@apache.org>.
luocooong commented on pull request #2150:
URL: https://github.com/apache/drill/pull/2150#issuecomment-770151316


   @cgivre Thanks. All done.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] luocooong merged pull request #2150: DRILL-7827: Move the Pcapng format plugin to contrib folder

Posted by GitBox <gi...@apache.org>.
luocooong merged pull request #2150:
URL: https://github.com/apache/drill/pull/2150


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org