You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/09/11 08:49:25 UTC

[GitHub] [iotdb-web-workbench] NiklasMerz commented on pull request #2: feat(project)添加前端项目

NiklasMerz commented on pull request #2:
URL: https://github.com/apache/iotdb-web-workbench/pull/2#issuecomment-917369842


   A good way to check code for Apache headers is to use [Apache RAT](https://creadur.apache.org/rat/). 
   
   For this PR I get the following output:
   
   ```
   java -jar ~/apache-rat-0.13.jar .
   
   *****************************************************
   Summary
   -------
   Generated at: 2021-09-11T10:30:33+02:00
   
   Notes: 2
   Binaries: 6
   Archives: 0
   Standards: 73
   
   Apache Licensed: 62
   Generated Documents: 0
   
   JavaDocs are generated, thus a license header is optional.
   Generated files do not require license headers.
   
   11 Unknown Licenses
   
   *****************************************************
   
   Files with unapproved licenses:
   
     ./.gitignore
     ./NOTICE-binary
     ./frontend/.browserslistrc
     ./frontend/.eslintignore
     ./frontend/.gitignore
     ./frontend/package-lock.json
     ./frontend/package.json
     ./frontend/public/iconfont.js
     ./frontend/src/shims-vue.d.ts
     ./frontend/src/store/index.js
     ./frontend/tests/unit/example.spec.js
   
   *****************************************************
   
   *****************************************************
   ```
   
   Some of those files are probably fine and they can be ignored (RAT has a .ratignore file for this).  But I would check the `.js` files again.
   
   I also had a brief look at the dependency licenses yarn gives me with `yarn licenses list` gives me and compared it with [Apaches policy](https://www.apache.org/legal/resolved.html). I did not find any issues so far.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org