You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by zuotingbing <gi...@git.apache.org> on 2017/03/31 09:36:23 UTC

[GitHub] spark pull request #17493: [SPARK-20173][SQL] Throw NullPointerException whe...

GitHub user zuotingbing opened a pull request:

    https://github.com/apache/spark/pull/17493

    [SPARK-20173][SQL] Throw NullPointerException when HiveThriftServer2 is shutdown

    ## What changes were proposed in this pull request?
    
    Throw NullPointerException when HiveThriftServer2 is shutdown
    
    ## How was this patch tested?
    
    manual tests
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zuotingbing/spark SPARK-HiveThriftServer2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/17493.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #17493
    
----
commit ab6c29daa0c5c84b9e05f0ea57238dbd0003a2a4
Author: zuotingbing <zu...@zte.com.cn>
Date:   2017-03-28T07:08:05Z

    [SPARK-20123]$SPARK_HOME variable might have spaces in it(e.g. $SPARK_HOME=/home/spark build/spark), then build spark failed.

commit bcf95991282904c259979c4cfe6b6df293df8edb
Author: zuotingbing <zu...@zte.com.cn>
Date:   2017-03-29T09:36:13Z

    codereview:quote whole arguments that include a variable for completeness

commit c50b49e6465cf89d74db86944277ae0fb6f66bde
Author: zuotingbing <zu...@zte.com.cn>
Date:   2017-03-31T09:21:01Z

    Throw NullPointerException when HiveThriftServer2 is shutdown

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17493: [SPARK-20173][SQL] Throw NullPointerException when HiveT...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17493
  
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17493: [SPARK-20173][SQL] Throw NullPointerException when HiveT...

Posted by zuotingbing <gi...@git.apache.org>.
Github user zuotingbing commented on the issue:

    https://github.com/apache/spark/pull/17493
  
    @srowen yes, i will fix it right now. Thanks!  :)
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17493: [SPARK-20173][SQL] Throw NullPointerException when HiveT...

Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/17493
  
    @zuotingbing i think you included the wrong changes here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #17493: [SPARK-20173][SQL] Throw NullPointerException whe...

Posted by zuotingbing <gi...@git.apache.org>.
Github user zuotingbing closed the pull request at:

    https://github.com/apache/spark/pull/17493


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org