You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/07 15:58:12 UTC
[GitHub] [flink] tillrohrmann commented on a change in pull request #17414: [FLINK-24451][HA]Replace the scattered objects with encapsulated LeaderIn…
tillrohrmann commented on a change in pull request #17414:
URL: https://github.com/apache/flink/pull/17414#discussion_r724319224
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java
##########
@@ -263,13 +257,11 @@ public void onLeaderInformationChange(LeaderInformation leaderInformation) {
LOG.trace(
"Leader node changed while {} is the leader with session ID {}. New leader information {}.",
leaderContender.getDescription(),
- confirmedLeaderSessionID,
+ confirmedLeaderInformation.getLeaderSessionID(),
leaderInformation);
}
- if (confirmedLeaderSessionID != null) {
- final LeaderInformation confirmedLeaderInfo =
- LeaderInformation.known(
- confirmedLeaderSessionID, confirmedLeaderAddress);
+ if (confirmedLeaderInformation.getLeaderSessionID() != null) {
Review comment:
```suggestion
if (!confirmedLeaderInformation.isEmpty()) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org