You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@burr.apache.org by "Mr-Ruben (via GitHub)" <gi...@apache.org> on 2025/06/20 11:39:36 UTC

[I] serde caveats ? [burr]

Mr-Ruben opened a new issue, #554:
URL: https://github.com/apache/burr/issues/554

   
   
   Please, correct me if I am wrong.
   
   
   If one does use this
   
   ```python
   from burr.core import ApplicationBuilder
   from burr.integrations.pydantic import PydanticTypingSystem
   
   app = (
       ApplicationBuilder()
       .with_actions(...)
       .with_entrypoint(...)
       .with_transitions(...)
       .with_typing(PydanticTypingSystem(ApplicationState))
       .with_state(ApplicationState())
       .build()
   )
   ```
   
   
   this won't have any effect (is useless)
   
   
   ```python
   from typing import Any, Dict
   from burr.core import serde
   
   @serde.serialize.register(ApplicationState)
   def serialize_myclass(value: ApplicationState, myclass_kwargs: dict = None, **kwargs) -> dict:
       """Serializes the value using my custom methodology.
   
       ...
   
   ```
   
   
   nor this
   
   
   
   ```python
   from burr.core import ApplicationBuilder, State 
   
   from typing import Any, Dict
   from burr.core import serde
   
   @serde.serialize.register(State)
   def serialize_myclass(value: State, myclass_kwargs: dict = None, **kwargs) -> dict:
       """Serializes the value using my custom methodology.
   
       ...
   
   ```
   
   
   however, if I am not mistaken, https://burr.dagworks.io/concepts/serde/ does not mention those 2 important limitations / caveats.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@burr.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] serde caveats ? [burr]

Posted by "skrawcz (via GitHub)" <gi...@apache.org>.
skrawcz commented on issue #554:
URL: https://github.com/apache/burr/issues/554#issuecomment-2993356681

   @Mr-Ruben side comment -- to confirm does the field level serialization achieve what you need?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@burr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] serde caveats ? [burr]

Posted by "Mr-Ruben (via GitHub)" <gi...@apache.org>.
Mr-Ruben commented on issue #554:
URL: https://github.com/apache/burr/issues/554#issuecomment-2993672903

   I entered into the 'serialization' space because I had an error on a specific stage and I thought it was because Burr had issues serializing the state.
   
   At the end it had nothing to do with serialization, so I don't need to modify / use it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@burr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] serde caveats ? [burr]

Posted by "Mr-Ruben (via GitHub)" <gi...@apache.org>.
Mr-Ruben commented on issue #554:
URL: https://github.com/apache/burr/issues/554#issuecomment-2992627221

   https://github.com/apache/burr/pull/555
   
   > Does that answer your question?
   Yes, thanks.
   I just did not want others to waste their time doing what I did.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@burr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] serde caveats ? [burr]

Posted by "skrawcz (via GitHub)" <gi...@apache.org>.
skrawcz commented on issue #554:
URL: https://github.com/apache/burr/issues/554#issuecomment-2992450753

   @Mr-Ruben ah hadn't thought it could be interpreted that way! The registration was meant for classes against fields in state -- not the entire state object itself. We should add something to the docs -- mind opening up a PR for that?
   
   Does that answer your question?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@burr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] serde caveats ? [burr]

Posted by "Mr-Ruben (via GitHub)" <gi...@apache.org>.
Mr-Ruben closed issue #554: serde caveats ?
URL: https://github.com/apache/burr/issues/554


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@burr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org