You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/22 14:32:20 UTC
[GitHub] [airflow] BobDu opened a new pull request, #26598: Add statsd overrideMappings in helm chart values
BobDu opened a new pull request, #26598:
URL: https://github.com/apache/airflow/pull/26598
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
I think, it will a part of the PR #25219 .
Let's do some easier part first and roll it out to users.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #26598: Add statsd overrideMappings in helm chart values
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #26598:
URL: https://github.com/apache/airflow/pull/26598
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26598: Add statsd overrideMappings in helm chart values
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26598:
URL: https://github.com/apache/airflow/pull/26598#issuecomment-1259474604
> In addition, I have to say that the reason why I don't use the docker hub as much as possible.
https://www.docker.com/increase-rate-limits/
Yeah, I am well aware of that. Just FYI - all ASF images (those under apache/* ) are exempt from the limit - this is one of the reasons we have our own customized image in the "apache/*" part of the registry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26598: Add statsd overrideMappings in helm chart values
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26598:
URL: https://github.com/apache/airflow/pull/26598#issuecomment-1255443211
Tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] BobDu commented on pull request #26598: Add statsd overrideMappings in helm chart values
Posted by GitBox <gi...@apache.org>.
BobDu commented on PR #26598:
URL: https://github.com/apache/airflow/pull/26598#issuecomment-1256151642
> Tests?
Sorry, fix all test failing already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] BobDu commented on pull request #26598: Add statsd overrideMappings in helm chart values
Posted by GitBox <gi...@apache.org>.
BobDu commented on PR #26598:
URL: https://github.com/apache/airflow/pull/26598#issuecomment-1259466811
> BTW. Seems like we can get rid of one of our images. And RedHat/Quay.io by RedHat looks credible enough for me.
Of course, look this, repository `quay.io/prometheus` is maintain by prometheus official community.
https://prometheus.io/docs/prometheus/latest/installation/#using-docker
In addition, I have to say that the reason why I don't use the docker hub as much as possible.
https://www.docker.com/increase-rate-limits/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26598: Add statsd overrideMappings in helm chart values
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26598:
URL: https://github.com/apache/airflow/pull/26598#issuecomment-1259448449
BTW. Seems like we can get rid of one of our images. And RedHat/Quay.io by RedHat looks credible enough for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26598: Add statsd overrideMappings in helm chart values
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26598:
URL: https://github.com/apache/airflow/pull/26598#issuecomment-1259444767
THis looks cool to me. @jedcunningham @dstandish ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org