You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@subversion.apache.org by Bhuvaneswaran Arumugam <bh...@collab.net> on 2006/11/28 10:30:59 UTC

[PATCH] Avoid importing unused libraries in tests scripts

Hello,

This is a follow-up for r22444. This time it fixes the issues in scripts
under tests/cmdline/svntest directory. Please find attached the patch
for review.

[[
Avoid importing unused python libraries in the black box regression
tests.

[ in subversion/tests/cmdline/svntest ]
* testcase.py
  Do not import unused libraries.
  (TestCase.check_description): Use the string itself when invoking the
  lower() function.

* tree.py 
  Do not import unused libraries.
  (create_from_path, dump_tree): Use the string itself when invoking the
  replace() function.
  (get_props): Use the string itself when invoking the strip() function.

* actions.py
  Do not import unused libraries.
  (setup_pristine_repository, run_and_verify_commit): Use the string
  itself when invoking strip() function.

* main.py
  Do not import unused libraries.
  Use the string itself when invoking replace() function.
  (Sandbox._set_name, run_tests): Use the string itself when invoking
  replace() function.

Patch by: bhuvan
]]

-- 
Regards,
Bhuvaneswaran

Re: [PATCH] Avoid importing unused libraries in tests scripts

Posted by Bhuvaneswaran Arumugam <bh...@collab.net>.

On Tue, 2006-11-28 at 08:35 -0800, Daniel Rall wrote:
> On Tue, 28 Nov 2006, Bhuvaneswaran Arumugam wrote:
> 
> > Hello,
> > 
> > This is a follow-up for r22444. This time it fixes the issues in scripts
> > under tests/cmdline/svntest directory. Please find attached the patch
> > for review.
> > 
> > [[
> > Avoid importing unused python libraries in the black box regression
> > tests.
...
> Looks good, Bhuvan.  Please commit to trunk.

Thanks Dan, Committed to trunk in r22512.
-- 
Regards,
Bhuvaneswaran

Re: [PATCH] Avoid importing unused libraries in tests scripts

Posted by Daniel Rall <dl...@collab.net>.

On Tue, 28 Nov 2006, Bhuvaneswaran Arumugam wrote:

> Hello,
> 
> This is a follow-up for r22444. This time it fixes the issues in scripts
> under tests/cmdline/svntest directory. Please find attached the patch
> for review.
> 
> [[
> Avoid importing unused python libraries in the black box regression
> tests.
> 
> [ in subversion/tests/cmdline/svntest ]
> * testcase.py
>   Do not import unused libraries.
>   (TestCase.check_description): Use the string itself when invoking the
>   lower() function.
> 
> * tree.py 
>   Do not import unused libraries.
>   (create_from_path, dump_tree): Use the string itself when invoking the
>   replace() function.
>   (get_props): Use the string itself when invoking the strip() function.
> 
> * actions.py
>   Do not import unused libraries.
>   (setup_pristine_repository, run_and_verify_commit): Use the string
>   itself when invoking strip() function.
> 
> * main.py
>   Do not import unused libraries.
>   Use the string itself when invoking replace() function.
>   (Sandbox._set_name, run_tests): Use the string itself when invoking
>   replace() function.
> 
> Patch by: bhuvan
> ]]

Looks good, Bhuvan.  Please commit to trunk.

- Dan