[GitHub] [incubator-flagon-useralejs] poorejc commented on issue #50: sendOnClose function broken -- logs dropped when users navigate away from page

[GitBox <gi...@apache.org>]

poorejc commented on issue #50:
URL: https://github.com/apache/incubator-flagon-useralejs/issues/50#issuecomment-812314024


   > I finished up the spike and put it in a branch [here](https://github.com/UncleGedd/incubator-flagon-useralejs/tree/spike-workers). I was able to get a decent unit test in, but not a journey test. Currently, cypress does not support intercepting requests from workers. This solution works well in Chrome but not in Safari due to the lack of `visibilitychange` event support, and I haven't tested in Edge or IE. If you all like this solution, I'll continue the spike and start testing for other browsers.
   
   I cloned your branch @UncleGedd. Doing some testing I'm getting really inconsistent behavior. Rebuilding everything, I'm not seeing that our filters are getting applied, or that custom logs are being generated. That's wonky, so I want to test again tomorrow. Not sure why that's happening, but it could be my env and I want to start clean tomorrow and test methodically with fresh clones and clear cache. I'll also pull your branch into useralejs repo (new branch).
   
   I noticed that your branch doesn't remove sendOnRefresh from sendlogs (or refresh events in /src/attachHandlers). That would send submit logs when the page was refreshed without using sendOnClose...
   
   Also, the new JSDOM test is failing for me. I get this error:
   
     1) sendLogs
          flushes the log queue on visibility change:
        TypeError: Failed to execute 'dispatchEvent' on 'EventTarget': parameter 1 is not of type 'Event'.
         at Object.exports.convert (node_modules/jsdom/lib/jsdom/living/generated/Event.js:22:9)
         at Document.dispatchEvent (node_modules/jsdom/lib/jsdom/living/generated/EventTarget.js:228:24)
         at Context.<anonymous> (test/sendLogs_spec.js:132:25)
         at processImmediate (node:internal/timers:463:21)
   
   Can't find much wrong with your constructor, and didnt find much out digging through related issues on SO.
   
   Anyway, if you have the time and you want to test more: check to see that your not getting mouseovers on our example page (means filters aren't applying well). We should see custom decorated logs coming through clicking the first button. Also, removing sendOnRefresh from attachHandlers and sendLogs, if you see Submit events with webworkers, that makes me confident that they are working. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org