You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "s0nskar (via GitHub)" <gi...@apache.org> on 2023/07/08 03:34:26 UTC

[GitHub] [pinot] s0nskar commented on a diff in pull request #11057: Support for new dataTime format in `DateTimeGranularitySpec` without explicitly setting size

s0nskar commented on code in PR #11057:
URL: https://github.com/apache/pinot/pull/11057#discussion_r1256871324


##########
pinot-spi/src/main/java/org/apache/pinot/spi/data/DateTimeGranularitySpec.java:
##########
@@ -53,38 +55,49 @@ public DateTimeGranularitySpec(String granularity) {
     char separator;
     int sizePosition;
     int timeUnitPosition;
+    int minTokens = NUM_TOKENS;
+    int maxTokens = NUM_TOKENS;

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org