Re: [PR] Convert the string address into a PlcTag

["sruehl (via GitHub)" <gi...@apache.org>]

sruehl commented on code in PR #1468:
URL: https://github.com/apache/plc4x/pull/1468#discussion_r1572300698


##########
plc4j/drivers/ctrlx/src/main/java/org/apache/plc4x/java/ctrlx/readwrite/connection/CtrlXConnection.java:
##########
@@ -90,6 +93,17 @@ public void close() throws Exception {
         executorService.shutdown();
     }
 
+    @Override
+    public Optional<PlcTag> parseTagAddress(String tagAddress) {
+        PlcTag plcTag;
+        try {
+            plcTag = controlXTagHandler.parseTag(tagAddress);
+        } catch (Exception e) {

Review Comment:
   the Exception should be at least logged at a debug level or if it never matters the variable should be renamed to `ignore`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org