You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@plc4x.apache.org by "chrisdutz (via GitHub)" <gi...@apache.org> on 2024/09/04 15:54:12 UTC
[PR] Feature/modbus optimizer
chrisdutz opened a new pull request, #1744:
URL: https://github.com/apache/plc4x/pull/1744
Implemented an optimizer for Modbus in Java, that groups together individual items and loads chunks of bytes.
This needed quite a bit of updating which also had an effect on the generated code of almost every language we have.
However with this update the read speed of the ManualModbusTest increased by a factor of more than 10.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feature/modbus optimizer
Posted by "ottlukas (via GitHub)" <gi...@apache.org>.
ottlukas commented on PR #1744:
URL: https://github.com/apache/plc4x/pull/1744#issuecomment-2330777472
> No, it was just a Byte Array branch in the code gen that hadn't been used before. It was generating code that had a syntax error in it, that's why black couldn't reformat the file.
>
> By the way we are using black to firstly check for syntax errors, as well as clean up some of the formatting in the code gen output. That way we can be lazy and don't have to get the formatting in the code gen output exactly right.
[Black - The uncompromising code formatter](https://black.readthedocs.io/en/stable/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feature/modbus optimizer
Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz merged PR #1744:
URL: https://github.com/apache/plc4x/pull/1744
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feature/modbus optimizer
Posted by "hutcheb (via GitHub)" <gi...@apache.org>.
hutcheb commented on PR #1744:
URL: https://github.com/apache/plc4x/pull/1744#issuecomment-2329903468
@chrisdutz Yeah have to spend some time on fixing things when it comes to using the PlcValues, the Modbus write PR will include some fixes for it. But for now it passes the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feature/modbus optimizer
Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz commented on PR #1744:
URL: https://github.com/apache/plc4x/pull/1744#issuecomment-2330199607
Did I break anything with my addition?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feature/modbus optimizer
Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz commented on PR #1744:
URL: https://github.com/apache/plc4x/pull/1744#issuecomment-2329442593
@hutcheb and @ottlukas I could use your help on the python stuff ... should not be a huge change ... in other languages, if I have an array of byte byte that it uses the PlcRawByteArray instead of a List.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feature/modbus optimizer
Posted by "hutcheb (via GitHub)" <gi...@apache.org>.
hutcheb commented on PR #1744:
URL: https://github.com/apache/plc4x/pull/1744#issuecomment-2330299924
No, it was just a Byte Array branch in the code gen that hadn't been used before. It was generating code that had a syntax error in it, that's why black couldn't reformat the file.
By the way we are using black to firstly check for syntax errors, as well as clean up some of the formatting in the code gen output. That way we can be lazy and don't have to get the formatting in the code gen output exactly right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feature/modbus optimizer
Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz commented on PR #1744:
URL: https://github.com/apache/plc4x/pull/1744#issuecomment-2331105126
> No, it was just a Byte Array branch in the code gen that hadn't been used before. It was generating code that had a syntax error in it, that's why black couldn't reformat the file.
>
> By the way we are using black to firstly check for syntax errors, as well as clean up some of the formatting in the code gen output. That way we can be lazy and don't have to get the formatting in the code gen output exactly right.
As long as the output gives you a hint to what the problem is ... admittedly I was a bit lost and commented out black in order to get a sensible error report.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org