You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Harsh J (JIRA)" <ji...@apache.org> on 2012/04/22 19:55:40 UTC
[jira] [Created] (MAPREDUCE-4183) Clean up yarn-common
Harsh J created MAPREDUCE-4183:
----------------------------------
Summary: Clean up yarn-common
Key: MAPREDUCE-4183
URL: https://issues.apache.org/jira/browse/MAPREDUCE-4183
Project: Hadoop Map/Reduce
Issue Type: Sub-task
Components: build
Affects Versions: trunk
Reporter: Harsh J
Assignee: Harsh J
Priority: Minor
Clean up a bunch of existing javac warnings in hadoop-yarn-common module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4183) Clean up yarn-common
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259286#comment-13259286 ]
Hadoop QA commented on MAPREDUCE-4183:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12523716/0011-YARN-Common-Cleanup.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 7 new or modified test files.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.yarn.server.TestContainerManagerSecurity
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2288//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2288//console
This message is automatically generated.
> Clean up yarn-common
> --------------------
>
> Key: MAPREDUCE-4183
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4183
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build
> Affects Versions: trunk
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Attachments: 0011-YARN-Common-Cleanup.patch, 0011-YARN-Common-Cleanup.patch
>
>
> Clean up a bunch of existing javac warnings in hadoop-yarn-common module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4183) Clean up yarn-common
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated MAPREDUCE-4183:
-------------------------------
Status: Open (was: Patch Available)
Cancelled patch to address Tom and Nicholas' comments.
> Clean up yarn-common
> --------------------
>
> Key: MAPREDUCE-4183
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4183
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build
> Affects Versions: trunk
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Attachments: 0011-YARN-Common-Cleanup.patch, 0011-YARN-Common-Cleanup.patch
>
>
> Clean up a bunch of existing javac warnings in hadoop-yarn-common module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (MAPREDUCE-4183) Clean up yarn-common
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J resolved MAPREDUCE-4183.
--------------------------------
Resolution: Won't Fix
Patches were too broad and have gone stale. Will address these forms of issue over separate, smaller and more divided JIRAs in future.
Closing out parent JIRA MAPREDUCE-4172, and hence closing out this.
> Clean up yarn-common
> --------------------
>
> Key: MAPREDUCE-4183
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4183
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build
> Affects Versions: trunk
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Attachments: 0011-YARN-Common-Cleanup.patch, 0011-YARN-Common-Cleanup.patch
>
>
> Clean up a bunch of existing javac warnings in hadoop-yarn-common module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4183) Clean up yarn-common
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259291#comment-13259291 ]
Harsh J commented on MAPREDUCE-4183:
------------------------------------
{{org.apache.hadoop.yarn.server.TestContainerManagerSecurity}} failure appears unrelated to this clean up patch.
> Clean up yarn-common
> --------------------
>
> Key: MAPREDUCE-4183
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4183
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build
> Affects Versions: trunk
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Attachments: 0011-YARN-Common-Cleanup.patch, 0011-YARN-Common-Cleanup.patch
>
>
> Clean up a bunch of existing javac warnings in hadoop-yarn-common module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4183) Clean up yarn-common
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13265574#comment-13265574 ]
Tom White commented on MAPREDUCE-4183:
--------------------------------------
I don't think we need to add serialVersionUID to classes - its absence shouldn't cause javac warnings.
> Clean up yarn-common
> --------------------
>
> Key: MAPREDUCE-4183
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4183
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build
> Affects Versions: trunk
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Attachments: 0011-YARN-Common-Cleanup.patch, 0011-YARN-Common-Cleanup.patch
>
>
> Clean up a bunch of existing javac warnings in hadoop-yarn-common module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4183) Clean up yarn-common
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259226#comment-13259226 ]
Hadoop QA commented on MAPREDUCE-4183:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12523704/0011-YARN-Common-Cleanup.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 7 new or modified test files.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.yarn.server.nodemanager.TestNodeStatusUpdater
org.apache.hadoop.yarn.server.nodemanager.webapp.TestNMWebServer
org.apache.hadoop.yarn.server.TestDiskFailures
org.apache.hadoop.yarn.server.TestContainerManagerSecurity
org.apache.hadoop.yarn.applications.distributedshell.TestDistributedShell
org.apache.hadoop.yarn.webapp.TestWebApp
org.apache.hadoop.yarn.TestRpcFactoryProvider
org.apache.hadoop.mapreduce.v2.TestMiniMRProxyUser
org.apache.hadoop.mapred.TestClusterMRNotification
org.apache.hadoop.mapreduce.v2.TestSpeculativeExecution
org.apache.hadoop.mapred.TestSpecialCharactersInOutputPath
org.apache.hadoop.mapreduce.v2.TestRMNMInfo
org.apache.hadoop.mapred.TestMiniMRClasspath
org.apache.hadoop.mapreduce.v2.TestMRAppWithCombiner
org.apache.hadoop.mapred.TestReduceFetchFromPartialMem
org.apache.hadoop.mapred.TestLazyOutput
org.apache.hadoop.mapreduce.v2.TestMRJobsWithHistoryService
org.apache.hadoop.mapreduce.TestChild
org.apache.hadoop.mapred.TestReduceFetch
org.apache.hadoop.mapred.TestMiniMRBringup
org.apache.hadoop.mapred.TestClusterMapReduceTestCase
org.apache.hadoop.mapreduce.security.TestJHSSecurity
org.apache.hadoop.mapred.TestMiniMRClientCluster
org.apache.hadoop.mapreduce.lib.output.TestJobOutputCommitter
org.apache.hadoop.mapreduce.v2.TestMROldApiJobs
org.apache.hadoop.mapreduce.v2.TestNonExistentJob
org.apache.hadoop.mapred.TestMiniMRChildTask
org.apache.hadoop.mapred.TestJobCounters
org.apache.hadoop.mapreduce.v2.TestUberAM
org.apache.hadoop.conf.TestNoDefaultsJobConf
org.apache.hadoop.mapred.TestJobName
org.apache.hadoop.mapred.TestJobSysDirWithDFS
org.apache.hadoop.mapreduce.v2.TestMRJobs
org.apache.hadoop.mapred.TestJobCleanup
org.apache.hadoop.mapreduce.TestMapReduceLazyOutput
org.apache.hadoop.ipc.TestSocketFactory
org.apache.hadoop.mapred.TestMiniMRWithDFSWithDistinctUsers
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2280//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2280//console
This message is automatically generated.
> Clean up yarn-common
> --------------------
>
> Key: MAPREDUCE-4183
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4183
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build
> Affects Versions: trunk
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Attachments: 0011-YARN-Common-Cleanup.patch
>
>
> Clean up a bunch of existing javac warnings in hadoop-yarn-common module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4183) Clean up yarn-common
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated MAPREDUCE-4183:
-------------------------------
Attachment: 0011-YARN-Common-Cleanup.patch
A bad cast from my changes in the reflection areas of some factories and the Router class caused most of these failures.
Those bad casts are fixed in this patch now.
> Clean up yarn-common
> --------------------
>
> Key: MAPREDUCE-4183
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4183
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build
> Affects Versions: trunk
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Attachments: 0011-YARN-Common-Cleanup.patch, 0011-YARN-Common-Cleanup.patch
>
>
> Clean up a bunch of existing javac warnings in hadoop-yarn-common module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4183) Clean up yarn-common
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13265595#comment-13265595 ]
Tsz Wo (Nicholas), SZE commented on MAPREDUCE-4183:
---------------------------------------------------
Please do not add @SuppressWarnings(..). Remove them or fixing the warnings are great.
> Clean up yarn-common
> --------------------
>
> Key: MAPREDUCE-4183
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4183
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build
> Affects Versions: trunk
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Attachments: 0011-YARN-Common-Cleanup.patch, 0011-YARN-Common-Cleanup.patch
>
>
> Clean up a bunch of existing javac warnings in hadoop-yarn-common module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4183) Clean up yarn-common
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated MAPREDUCE-4183:
-------------------------------
Attachment: 0011-YARN-Common-Cleanup.patch
Patch that cleans up all warnings from hadoop-yarn-common
> Clean up yarn-common
> --------------------
>
> Key: MAPREDUCE-4183
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4183
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build
> Affects Versions: trunk
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Attachments: 0011-YARN-Common-Cleanup.patch
>
>
> Clean up a bunch of existing javac warnings in hadoop-yarn-common module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4183) Clean up yarn-common
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated MAPREDUCE-4183:
-------------------------------
Status: Patch Available (was: Open)
> Clean up yarn-common
> --------------------
>
> Key: MAPREDUCE-4183
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4183
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build
> Affects Versions: trunk
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Attachments: 0011-YARN-Common-Cleanup.patch
>
>
> Clean up a bunch of existing javac warnings in hadoop-yarn-common module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira