[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #9094: [WIP] Enhance event loop initialization

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on code in PR #9094:
URL: https://github.com/apache/pinot/pull/9094#discussion_r928071532


##########
pinot-core/src/main/java/org/apache/pinot/core/transport/ServerChannels.java:
##########
@@ -64,6 +68,7 @@
 public class ServerChannels {
   public static final String CHANNEL_LOCK_TIMEOUT_MSG = "Timeout while acquiring channel lock";
   private static final long TRY_CONNECT_CHANNEL_LOCK_TIMEOUT_MS = 5_000L;
+  public static final Logger LOGGER = LoggerFactory.getLogger(ServerChannels.class);

Review Comment:
   (minor) Make it `private static final`



##########
pinot-core/src/main/java/org/apache/pinot/core/transport/QueryServer.java:
##########
@@ -57,10 +61,11 @@ public class QueryServer {
   private final ServerMetrics _serverMetrics;
   private final TlsConfig _tlsConfig;
   private final AccessControl _accessControl;
+  public static final Logger LOGGER = LoggerFactory.getLogger(QueryServer.class);

Review Comment:
   (minor) Make it `private static final` and move it ahead of other non-static fields.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org