You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ma...@apache.org on 2017/09/12 16:05:10 UTC
[incubator-superset] branch master updated: [explore] checkbox
control won't uncheck (#3454)
This is an automated email from the ASF dual-hosted git repository.
maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
The following commit(s) were added to refs/heads/master by this push:
new fe77534 [explore] checkbox control won't uncheck (#3454)
fe77534 is described below
commit fe77534c03c12ea59baa9bad9391fcd692540806
Author: Maxime Beauchemin <ma...@gmail.com>
AuthorDate: Tue Sep 12 09:05:07 2017 -0700
[explore] checkbox control won't uncheck (#3454)
---
.../javascripts/explore/components/controls/CheckboxControl.jsx | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/superset/assets/javascripts/explore/components/controls/CheckboxControl.jsx b/superset/assets/javascripts/explore/components/controls/CheckboxControl.jsx
index 7d78646..a4138e4 100644
--- a/superset/assets/javascripts/explore/components/controls/CheckboxControl.jsx
+++ b/superset/assets/javascripts/explore/components/controls/CheckboxControl.jsx
@@ -19,8 +19,8 @@ const defaultProps = {
const checkboxStyle = { paddingRight: '5px' };
export default class CheckboxControl extends React.Component {
- onChange(checked) {
- this.props.onChange(checked);
+ onChange() {
+ this.props.onChange(!this.props.value);
}
render() {
return (
--
To stop receiving notification emails like this one, please contact
['"commits@superset.apache.org" <co...@superset.apache.org>'].