You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/06 22:43:05 UTC

[GitHub] [airflow] jhtimmins commented on a change in pull request #12846: Fix login error warning

jhtimmins commented on a change in pull request #12846:
URL: https://github.com/apache/airflow/pull/12846#discussion_r537141002



##########
File path: airflow/www/auth.py
##########
@@ -32,9 +32,6 @@ def decorated(*args, **kwargs):
             appbuilder = current_app.appbuilder
             if appbuilder.sm.check_authorization(permissions, request.args.get('dag_id', None)):
                 return func(*args, **kwargs)
-            else:
-                access_denied = "Access is Denied"
-                flash(access_denied, "danger")

Review comment:
       @ashb ok I updated it. I realized a lot of CRUD paths use the built-in FAB routing and access controls and never even use this function. So instead I just modified `flash.html` to hide this specific error on the login page. Not the prettiest solution, but at least it's consistent.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org