You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/06/08 10:56:42 UTC

[GitHub] [ignite-3] isapego commented on a diff in pull request #865: IGNITE-17057 Implement synchronous SQL API for java client

isapego commented on code in PR #865:
URL: https://github.com/apache/ignite-3/pull/865#discussion_r892212522


##########
modules/client/src/main/java/org/apache/ignite/internal/client/sql/ClientAsyncResultSet.java:
##########
@@ -145,6 +145,11 @@ public CompletionStage<? extends AsyncResultSet> fetchNextPage() {
                     readRows(r.in());
                     hasMorePages = r.in().unpackBoolean();
 
+                    if (!hasMorePages) {
+                        // When last page is fetched, server closes the cursor.
+                        closed = true;
+                    }
+

Review Comment:
   Good catch



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org