You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by GitBox <gi...@apache.org> on 2021/08/17 06:08:31 UTC

[GitHub] [jclouds] timuralp opened a new pull request #119: AzureBlob: Active Directory Auth

timuralp opened a new pull request #119:
URL: https://github.com/apache/jclouds/pull/119


       Implements the Azure AD authentication for Azure Blob, using the OAuth
       module. Added more parameters to the AzureBlob provider:
       - azureblob.auth
       - azureblob.account
       - azureblob.tenantId
       
       The "auth" parameter is used to specify whether Key/SAS auth or Active
       Directory is used. When using Active Directory auth, the identity no
       longer maps to the storage account, which has to be specified
       explicitly. The tenant ID also needs to be supplied to construct the
       auth URL to obtain the token correctly.
       
       Fixes #1558
       
       Another commit is required to bump the API version to enable Active Directory authentication.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@jclouds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jclouds] gaul merged pull request #119: JCLOUDS-1558: AzureBlob: Active Directory Auth

Posted by GitBox <gi...@apache.org>.
gaul merged pull request #119:
URL: https://github.com/apache/jclouds/pull/119


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@jclouds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jclouds] gaul commented on pull request #119: JCLOUDS-1558: AzureBlob: Active Directory Auth

Posted by GitBox <gi...@apache.org>.
gaul commented on pull request #119:
URL: https://github.com/apache/jclouds/pull/119#issuecomment-901087348


   @timuralp Could you prefix the commit with JCLOUDS-1558: which will tag the issue automatically?  Also please rebase the PR since I pushed the API update separately.
   
   @roded It looks like you started on a similar commit.  Would you mind reviewing and testing this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@jclouds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jclouds] roded commented on pull request #119: JCLOUDS-1558: AzureBlob: Active Directory Auth

Posted by GitBox <gi...@apache.org>.
roded commented on pull request #119:
URL: https://github.com/apache/jclouds/pull/119#issuecomment-903223501


   I'll attempt to replace our internal implementation with this PR's and report back.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@jclouds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jclouds] gaul commented on pull request #119: JCLOUDS-1558: AzureBlob: Active Directory Auth

Posted by GitBox <gi...@apache.org>.
gaul commented on pull request #119:
URL: https://github.com/apache/jclouds/pull/119#issuecomment-901087348


   @timuralp Could you prefix the commit with JCLOUDS-1558: which will tag the issue automatically?  Also please rebase the PR since I pushed the API update separately.
   
   @roded It looks like you started on a similar commit.  Would you mind reviewing and testing this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@jclouds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jclouds] gaul commented on pull request #119: JCLOUDS-1558: AzureBlob: Active Directory Auth

Posted by GitBox <gi...@apache.org>.
gaul commented on pull request #119:
URL: https://github.com/apache/jclouds/pull/119#issuecomment-903263720


   @roded Great!  I hope to release jclouds 2.4.0 next month so hopefully we can get any required changes merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@jclouds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jclouds] gaul commented on pull request #119: JCLOUDS-1558: AzureBlob: Active Directory Auth

Posted by GitBox <gi...@apache.org>.
gaul commented on pull request #119:
URL: https://github.com/apache/jclouds/pull/119#issuecomment-903223131


   Thanks for you contribution @timuralp!  This look fine although I only tested the traditional credentials for regressions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@jclouds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jclouds] gaul commented on pull request #119: AzureBlob: Active Directory Auth

Posted by GitBox <gi...@apache.org>.
gaul commented on pull request #119:
URL: https://github.com/apache/jclouds/pull/119#issuecomment-900255844


   @jmspring Can you help review this?
   
   @timuralp At first glance this looks fine other than the checkstyle failures.  Is there some tl;dr for testing with AD?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@jclouds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jclouds] timuralp commented on pull request #119: AzureBlob: Active Directory Auth

Posted by GitBox <gi...@apache.org>.
timuralp commented on pull request #119:
URL: https://github.com/apache/jclouds/pull/119#issuecomment-900020002


   @gaul I ran the live tests with the Azure AD credentials, but wonder if additional tests are required? Which additional unit tests would be helpful?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@jclouds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jclouds] gaul commented on pull request #119: AzureBlob: Active Directory Auth

Posted by GitBox <gi...@apache.org>.
gaul commented on pull request #119:
URL: https://github.com/apache/jclouds/pull/119#issuecomment-900276216


   @timuralp Please open an issue so we can capture this in the release notes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@jclouds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jclouds] roded commented on pull request #119: JCLOUDS-1558: AzureBlob: Active Directory Auth

Posted by GitBox <gi...@apache.org>.
roded commented on pull request #119:
URL: https://github.com/apache/jclouds/pull/119#issuecomment-925651690


   Hi @gaul  & @timuralp,
   I've managed to successfully replace our proprietary OAuth2 azureblob implementation with the one implemented in this PR and it seems to be working just fine. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@jclouds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org