[Bug 3252] New: known named colours trigger HTML_FONTCOLOR_UNKNOWN

[bu...@bugzilla.spamassassin.org]

http://bugzilla.spamassassin.org/show_bug.cgi?id=3252

           Summary: known named colours trigger HTML_FONTCOLOR_UNKNOWN
           Product: Spamassassin
           Version: 2.63
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P5
         Component: Rules (Eval Tests)
        AssignedTo: spamassassin-dev@incubator.apache.org
        ReportedBy: kjetilho@ifi.uio.no


an HTML message containing color=black is tagged with HTML_FONTCOLOR_UNKNOWN. 
the code simply looks wrong:

Mail/SpamAssassin/HTML.pm:
    if ($fg !~ /^\#?[0-9a-f]{6}$/ && !exists $html_color{$fg})
    {
      $self->{html}{font_color_name} = 1;
    }
    if ($fg =~ /^\#?([0-9a-f]{2})([0-9a-f]{2})([0-9a-f]{2})$/) {
    [...]
    }
    else {
      $self->{html}{font_color_unknown} = 1;
    }

in other words, you _have_ to use hex values to avoid triggering the rule.

what's the intended difference between

describe HTML_FONTCOLOR_NAME    HTML font color has unusual name
describe HTML_FONTCOLOR_UNKNOWN HTML font color is unknown to us

perhaps the right fix is to get rid of the latter rule.  the first one seems to
work as described, at least.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.