You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by harishreedharan <gi...@git.apache.org> on 2014/09/02 22:03:43 UTC
[GitHub] spark pull request: [SPARK-3352][STREAMING] Rename FlumePollingInp...
GitHub user harishreedharan opened a pull request:
https://github.com/apache/spark/pull/2238
[SPARK-3352][STREAMING] Rename FlumePollingInputDStream to FlumePullBase...
...dInputDStream.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/harishreedharan/spark rename-flume-dstream
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/2238.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2238
----
commit c82e2d0056ec5f9b0dd2ca7103a887378572d77e
Author: Hari Shreedharan <hs...@apache.org>
Date: 2014-09-02T20:00:29Z
[SPARK-3352][STREAMING] Rename FlumePollingInputDStream to FlumePullBasedInputDStream.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3352][STREAMING] Rename FlumePollingInp...
Posted by harishreedharan <gi...@git.apache.org>.
Github user harishreedharan commented on the pull request:
https://github.com/apache/spark/pull/2238#issuecomment-54375912
I am ok with closing this one out - it was a fairly easy to do (Intellij did most of the work)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3352][STREAMING] Rename FlumePollingInp...
Posted by harishreedharan <gi...@git.apache.org>.
Github user harishreedharan commented on the pull request:
https://github.com/apache/spark/pull/2238#issuecomment-54735979
Since the RC passed - I am closing this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3352][STREAMING] Rename FlumePollingInp...
Posted by harishreedharan <gi...@git.apache.org>.
Github user harishreedharan closed the pull request at:
https://github.com/apache/spark/pull/2238
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3352][STREAMING] Rename FlumePollingInp...
Posted by tdas <gi...@git.apache.org>.
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/2238#issuecomment-54375751
@harishreedharan Since the RC4 is out and it will probably pass, I am not sure that this is a good idea to do after 1.1 comes out. Public interfaces after. If RC4 does not make it (unlikely), I will think about this.
Also, I asked around a few others informally regarding whether the name change (it was my suggestion so I am the culprit) made sense, and to them PullBasedStream was no more or less intuitive than PollingStream. So entirely sure if this helps.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3352][STREAMING] Rename FlumePollingInp...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2238#issuecomment-54209877
[QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19602/consoleFull) for PR 2238 at commit [`c82e2d0`](https://github.com/apache/spark/commit/c82e2d0056ec5f9b0dd2ca7103a887378572d77e).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3352][STREAMING] Rename FlumePollingInp...
Posted by tdas <gi...@git.apache.org>.
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/2238#issuecomment-54376104
Let's see whether RC4 passes. Accordingly we can close this.
On Wed, Sep 3, 2014 at 3:14 PM, Hari Shreedharan <no...@github.com>
wrote:
> I am ok with closing this one out - it was a fairly easy to do (Intellij
> did most of the work)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/spark/pull/2238#issuecomment-54375912>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3352][STREAMING] Rename FlumePollingInp...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2238#issuecomment-54218360
[QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19602/consoleFull) for PR 2238 at commit [`c82e2d0`](https://github.com/apache/spark/commit/c82e2d0056ec5f9b0dd2ca7103a887378572d77e).
* This patch **passes** unit tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org