You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@jmeter.apache.org by bu...@apache.org on 2015/05/27 21:08:25 UTC

[Bug 57958] New: Failed assertions do not show in 'View Results Tree' when inside check for JMeterThread.last_sample_ok

https://bz.apache.org/bugzilla/show_bug.cgi?id=57958

            Bug ID: 57958
           Summary: Failed assertions do not show in 'View Results Tree'
                    when inside check for JMeterThread.last_sample_ok
           Product: JMeter
           Version: 2.13
          Hardware: PC
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Main
          Assignee: issues@jmeter.apache.org
          Reporter: imikla@gmail.com

Created attachment 32760
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=32760&action=edit
JMeter script demonstrating the problem described in this report.

In a test plan, there is a need to fire the logout step if login was successful
no matter which intermediate step fails.

In the test plan, the value of JMeterThread.last_sample_ok was used in an
if-controller with 'Evaluate for all children' turned on so that any failing
step inside the if-controller will skip the remaining steps.

This technique works, however, when assertions fail inside this if-controller,
they are not reported in the 'View Results Tree' as errors if 'Generate Parent
Sample' is enabled.

If these steps are not inside the above mentioned if-controller, they report
correctly even if 'Generate Parent Sample' is enabled.

Attached is an example JMeter script that demonstrates this problem stripped
down and with URLs replaced with wikipedia.org.

Running the script as posted, the 'View Results Tree' will only report logout.
The failure inside the previous if-controller that caused an error (due to an
assertion failure) is not reported.

If the if-controller 'Run Things' is moved outside the test for
JMeterThread.last_sample_ok, the error is reported correctly.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 57958] Transaction Controller in "Generate Parent Sample" mode : Failed assertions do not show in 'View Results Tree' when inside check for JMeterThread.last_sample_ok

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57958

lionel.najman@c-s.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |64354


Referenced Bugs:

https://bz.apache.org/bugzilla/show_bug.cgi?id=64354
[Bug 64354] Transaction Controller in "Generate Parent Sample" mode : Failed
assertions do not show in 'View Results Tree' when inside check for
JMeterThread.last_sample_ok
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 57958] Transaction Controller in "Generate Parent Sample" mode : Failed assertions do not show in 'View Results Tree' when inside check for JMeterThread.last_sample_ok

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57958

Andrey Pokhilko <ap...@ya.ru> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Andrey Pokhilko <ap...@ya.ru> ---
Date: Thu May 11 18:02:25 2017
New Revision: 1794861

URL: http://svn.apache.org/viewvc?rev=1794861&view=rev
Log:
Bug 57958 - Fix transaction sample not generated if thread stops/restarts

Added:
   
jmeter/trunk/test/src/org/apache/jmeter/control/TestTransactionController.java
Modified:
    jmeter/trunk/src/core/org/apache/jmeter/threads/JMeterThread.java
    jmeter/trunk/xdocs/changes.xml

Modified: jmeter/trunk/src/core/org/apache/jmeter/threads/JMeterThread.java
URL:
http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/threads/JMeterThread.java?rev=1794861&r1=1794860&r2=1794861&view=diff

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 57958] Transaction Controller : Failed assertions do not show in 'View Results Tree' when inside check for JMeterThread.last_sample_ok

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57958

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Hardware|PC                          |All
            Summary|Failed assertions do not    |Transaction Controller :
                   |show in 'View Results Tree' |Failed assertions do not
                   |when inside check for       |show in 'View Results Tree'
                   |JMeterThread.last_sample_ok |when inside check for
                   |                            |JMeterThread.last_sample_ok

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 57958] Failed assertions do not show in 'View Results Tree' when inside check for JMeterThread.last_sample_ok

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57958

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |p.mouawad@ubik-ingenierie.c
                   |                            |om
                 OS|                            |All

--- Comment #1 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Issue is due to TransactionController in Parent Sample mode generation.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 57958] Failed assertions do not show in 'View Results Tree' when inside check for JMeterThread.last_sample_ok

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57958

--- Comment #2 from Michael Aichlmayr <im...@gmail.com> ---
Errors should (and do in every other case) report to the View Results Tree
regardless of the status of the Generate Parent Sample check-box.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 57958] Transaction Controller in "Generate Parent Sample" mode : Failed assertions do not show in 'View Results Tree' when inside check for JMeterThread.last_sample_ok

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57958

--- Comment #6 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Hello,
Within Bug 61380, I changed a bit the fix here.

Can you please test again nightly build to ensure there is no regression ?
Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 57958] Transaction Controller in "Generate Parent Sample" mode : Failed assertions do not show in 'View Results Tree' when inside check for JMeterThread.last_sample_ok

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57958

--- Comment #4 from Artem Fedorov <ar...@blazemeter.com> ---
Created attachment 34989
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=34989&action=edit
Test plan that reproduces this bug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 57958] Failed assertions do not show in 'View Results Tree' when inside check for JMeterThread.last_sample_ok

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57958

--- Comment #3 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Hi,
I am not saying anything different, just pointing to root cause of your issue
which is clearly due to a bug in TransactionController behaviour.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 57958] Transaction Controller in "Generate Parent Sample" mode : Failed assertions do not show in 'View Results Tree' when inside check for JMeterThread.last_sample_ok

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57958

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Transaction Controller :    |Transaction Controller in
                   |Failed assertions do not    |"Generate Parent Sample"
                   |show in 'View Results Tree' |mode : Failed assertions do
                   |when inside check for       |not show in 'View Results
                   |JMeterThread.last_sample_ok |Tree' when inside check for
                   |                            |JMeterThread.last_sample_ok

-- 
You are receiving this mail because:
You are the assignee for the bug.