You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by Joel Koshy <jj...@gmail.com> on 2015/02/12 16:11:42 UTC

Re: Review Request 29912: Patch for KAFKA-1852

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29912/#review72166
-----------------------------------------------------------



core/src/main/scala/kafka/server/OffsetManager.scala
<https://reviews.apache.org/r/29912/#comment118171>

    Can we just add an exists(topic) method to metadataCache?
    
    That way we can just do something like offsetMetadata.groupBy((topicPartition, offsetMetadata) => metadataCache.contains(topicPartition.topic))


- Joel Koshy


On Jan. 19, 2015, 6:44 p.m., Sriharsha Chintalapani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29912/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2015, 6:44 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1852
>     https://issues.apache.org/jira/browse/KAFKA-1852
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-1852. OffsetCommitRequest can commit offset on unknown topic.
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/server/KafkaApis.scala ec8d9f7ba44741db40875458bd524c4062ad6a26 
>   core/src/main/scala/kafka/server/OffsetManager.scala 0bdd42fea931cddd072c0fff765b10526db6840a 
>   core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala 5b93239cdc26b5be7696f4e7863adb9fbe5f0ed5 
> 
> Diff: https://reviews.apache.org/r/29912/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sriharsha Chintalapani
> 
>