[GitHub] [hbase] saintstack commented on a change in pull request #2806: HBASE-24573 do-release should sign the commits and tag it creates

[GitBox <gi...@apache.org>]

saintstack commented on a change in pull request #2806:
URL: https://github.com/apache/hbase/pull/2806#discussion_r552201134



##########
File path: dev-support/create-release/release-build.sh
##########
@@ -136,19 +136,21 @@ if [[ "$1" == "tag" ]]; then
 
   git config user.name "$GIT_NAME"
   git config user.email "$GIT_EMAIL"
+  git config user.signingkey "${GPG_KEY}"
 
   # Create release version
   maven_set_version "$RELEASE_VERSION"
+  find . -name pom.xml -exec git add {} \;
   git add RELEASENOTES.md CHANGES.md
 
-  git commit -a -m "Preparing ${PROJECT} release $RELEASE_TAG; tagging and updates to CHANGES.md and RELEASENOTES.md"
+  git commit -s -m "Preparing ${PROJECT} release $RELEASE_TAG; tagging and updates to CHANGES.md and RELEASENOTES.md"
   log "Creating tag $RELEASE_TAG at the head of $GIT_BRANCH"
-  git tag "$RELEASE_TAG"
+  git tag -s -m "Via create-release" "$RELEASE_TAG"

Review comment:
       Your suggestion for the comments (on second thoughts) add no value. We are just adding the tag name as comment; i.e. adding no net info?
   
   Let me combine your suggestion and the original message ; I think it important to note the tag made by the release scripts as opposed to by a human.
   
   Tell me more about mvn release including the version number?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org