[jira] [Commented] (OAK-2912) Clear the modified and deleted map in PermissionHook after processing is complete

["angela (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-2912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14562795#comment-14562795 ] 

angela commented on OAK-2912:
-----------------------------

sure, will do.

[~chetanm], what i already see without taking a closer look: there is no test-case illustrating the issue and verifying that the modification actually has the desired effect. in the light of our aim to prevent bugs/escalations/... that would be a mandatory part of such a patch. can you provide this as well? thanks.

> Clear the modified and deleted map in PermissionHook after processing is complete
> ---------------------------------------------------------------------------------
>
>                 Key: OAK-2912
>                 URL: https://issues.apache.org/jira/browse/OAK-2912
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: security
>            Reporter: Chetan Mehrotra
>            Assignee: angela
>            Priority: Minor
>             Fix For: 1.3.0
>
>         Attachments: OAK-2912.patch
>
>
> {{PermissionHook}} has in memory state in {{modified}} and {{deleted}} maps. In case of repository migration which is implemented as a large commit this can consume quite a bit of memory. In one of the migration it was taking ~1 GB of memory.
> In a commit involving multiple commit hooks once {{PermissionHook}} has done the work it can clear that state so that memory is not held up untill all the hooks are applied. Specially as IndexingHook takes long time and also has some memory requirements



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)