[GitHub] [arrow] Dandandan commented on a change in pull request #9038: ARROW-10356: [Rust][DataFusion] Add support for is_in (WIP)

[GitBox <gi...@apache.org>]

Dandandan commented on a change in pull request #9038:
URL: https://github.com/apache/arrow/pull/9038#discussion_r550762173



##########
File path: rust/datafusion/src/logical_plan/expr.rs
##########
@@ -158,6 +158,15 @@ pub enum Expr {
         /// List of expressions to feed to the functions as arguments
         args: Vec<Expr>,
     },
+    /// Returns whether the list contains the expr value.
+    InList {
+        /// The value to compare
+        expr: Box<Expr>,
+        /// The low end of the range
+        list: Vec<Expr>,
+        /// Whether the expression is negated
+        negated: bool,

Review comment:
       Would be nice indeed for next PR, I think we could have a special case to match on Not (ListIn (...) in the formatter instead :+1: 

##########
File path: rust/datafusion/src/logical_plan/expr.rs
##########
@@ -158,6 +158,15 @@ pub enum Expr {
         /// List of expressions to feed to the functions as arguments
         args: Vec<Expr>,
     },
+    /// Returns whether the list contains the expr value.
+    InList {
+        /// The value to compare
+        expr: Box<Expr>,
+        /// The low end of the range
+        list: Vec<Expr>,
+        /// Whether the expression is negated
+        negated: bool,

Review comment:
       Would be nice indeed for a next PR, I think we could have a special case to match on Not (ListIn (...) in the formatter instead :+1: 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org