You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by st...@apache.org on 2024/01/16 01:01:26 UTC

(impala) 03/03: IMPALA-12714: Fix test_reduced_cardinality_by_filter for non-HDFS

This is an automated email from the ASF dual-hosted git repository.

stigahuang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit e071e6f053ceb8cb4536837f76e76610a34aa8f2
Author: Riza Suminto <ri...@cloudera.com>
AuthorDate: Mon Jan 15 08:45:34 2024 -0800

    IMPALA-12714: Fix test_reduced_cardinality_by_filter for non-HDFS
    
    test_reduced_cardinality_by_filter failed in non-HDFS environment
    because it assert for existence of '00:SCAN HDFS' in ExecSummary. This
    patch change that assertion to ignore the type of scan node from test
    query. Also marked the test with SkipIfNotHdfsMinicluster.plans
    decorator.
    
    Testing:
    - Pass test_reduced_cardinality_by_filter
    
    Change-Id: Icbf72687cc3c5a99aa0a0a74e229ed8c88ed06ef
    Reviewed-on: http://gerrit.cloudera.org:8080/20902
    Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 tests/query_test/test_observability.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/query_test/test_observability.py b/tests/query_test/test_observability.py
index 597dea515..27dcf8d10 100644
--- a/tests/query_test/test_observability.py
+++ b/tests/query_test/test_observability.py
@@ -872,6 +872,7 @@ class TestObservability(ImpalaTestSuite):
     assert len(re.findall('Single node plan created:', runtime_profile, re.M)) == 2
     assert len(re.findall('Distributed plan created:', runtime_profile, re.M)) == 2
 
+  @SkipIfNotHdfsMinicluster.plans
   def test_reduced_cardinality_by_filter(self):
     """IMPALA-12702: Check that ExecSummary shows the reduced cardinality estimation."""
     query_opts = {'compute_processing_cost': True}
@@ -882,7 +883,7 @@ class TestObservability(ImpalaTestSuite):
         where l1.o_custkey < 1000"""
     result = self.execute_query(query, query_opts)
     scan = result.exec_summary[10]
-    assert scan['operator'] == '00:SCAN HDFS'
+    assert '00:SCAN' in scan['operator']
     assert scan['num_rows'] == 39563
     assert scan['est_num_rows'] == 575771
     assert scan['detail'] == 'tpch_parquet.lineitem'