You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@uima.apache.org by "Michael Baessler (JIRA)" <ui...@incubator.apache.org> on 2008/03/12 15:40:51 UTC

[jira] Created: (UIMA-891) uima example annotator does not work with the new Result spec design

uima example annotator does not work with the new Result spec design
--------------------------------------------------------------------

                 Key: UIMA-891
                 URL: https://issues.apache.org/jira/browse/UIMA-891
             Project: UIMA
          Issue Type: Bug
          Components: Examples
    Affects Versions: 2.2.1
            Reporter: Michael Baessler
            Assignee: Michael Baessler
             Fix For: 2.2.2


Annotators does not produce any output result since the use the ResultSpec API in a wrong way

They do:
resultSpec.containsType("org.apache.uima.tutorial.TimeAnnot")
which checks the type for language x-unspecified

But the annotator only works for "en" as mentioned in the output spec so they have to do a check like:

resultSpec.containsType("org.apache.uima.tutorial.TimeAnnot","en")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (UIMA-891) uima example annotator does not work with the new Result spec design

Posted by "Michael Baessler (JIRA)" <ui...@incubator.apache.org>.
    [ https://issues.apache.org/jira/browse/UIMA-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12577909#action_12577909 ] 

Michael Baessler commented on UIMA-891:
---------------------------------------

When thinking again about this issue, I'm not sure if the current implementation is correct...

When calling 
  resultSpec.containsType("org.apache.uima.tutorial.TimeAnnot") 
it is checked if TimeAnnot is available for language x-unspecified, but if the type is just defined for language "en"
the result is false. To get true it is necessary to do
   resultSpec.containsType("org.apache.uima.tutorial.TimeAnnot","en")

But x-unspecified stand for all languages, so why do I get no results when
asking for 
   resultSpec.containsType("org.apache.uima.tutorial.TimeAnnot")

And what should happen when having the following case:
org.apache.uima.tutorial.TimeAnnot is defined for x-unspecified -> so this means for all types

What should happen when calling
   resultSpec.containsType("org.apache.uima.tutorial.TimeAnnot","en")
I think it should also return true.

Opinions?


> uima example annotator does not work with the new Result spec design
> --------------------------------------------------------------------
>
>                 Key: UIMA-891
>                 URL: https://issues.apache.org/jira/browse/UIMA-891
>             Project: UIMA
>          Issue Type: Bug
>          Components: Examples
>    Affects Versions: 2.2.1
>            Reporter: Michael Baessler
>            Assignee: Michael Baessler
>             Fix For: 2.2.2
>
>
> Annotators does not produce any output result since the use the ResultSpec API in a wrong way
> They do:
> resultSpec.containsType("org.apache.uima.tutorial.TimeAnnot")
> which checks the type for language x-unspecified
> But the annotator only works for "en" as mentioned in the output spec so they have to do a check like:
> resultSpec.containsType("org.apache.uima.tutorial.TimeAnnot","en")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (UIMA-891) uima example annotator does not work with the new Result spec design

Posted by "Michael Baessler (JIRA)" <ui...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/UIMA-891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Baessler reopened UIMA-891:
-----------------------------------


 resultSpec.containsType("org.apache.uima.tutorial.TimeAnnot","en") 

should be replaced with

 resultSpec.containsType("org.apache.uima.tutorial.TimeAnnot",aCAS.getDocumentLanguage()) 

> uima example annotator does not work with the new Result spec design
> --------------------------------------------------------------------
>
>                 Key: UIMA-891
>                 URL: https://issues.apache.org/jira/browse/UIMA-891
>             Project: UIMA
>          Issue Type: Bug
>          Components: Examples
>    Affects Versions: 2.2.1
>            Reporter: Michael Baessler
>            Assignee: Michael Baessler
>             Fix For: 2.2.2
>
>
> Annotators does not produce any output result since the use the ResultSpec API in a wrong way
> They do:
> resultSpec.containsType("org.apache.uima.tutorial.TimeAnnot")
> which checks the type for language x-unspecified
> But the annotator only works for "en" as mentioned in the output spec so they have to do a check like:
> resultSpec.containsType("org.apache.uima.tutorial.TimeAnnot","en")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (UIMA-891) uima example annotator does not work with the new Result spec design

Posted by "Michael Baessler (JIRA)" <ui...@incubator.apache.org>.
    [ https://issues.apache.org/jira/browse/UIMA-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12577950#action_12577950 ] 

Michael Baessler commented on UIMA-891:
---------------------------------------

This is a weird issue... My opinions change from one moment to the other.

Maybe for now we should go this strict way and use the API as is.

So I will go and fix the examples.

> uima example annotator does not work with the new Result spec design
> --------------------------------------------------------------------
>
>                 Key: UIMA-891
>                 URL: https://issues.apache.org/jira/browse/UIMA-891
>             Project: UIMA
>          Issue Type: Bug
>          Components: Examples
>    Affects Versions: 2.2.1
>            Reporter: Michael Baessler
>            Assignee: Michael Baessler
>             Fix For: 2.2.2
>
>
> Annotators does not produce any output result since the use the ResultSpec API in a wrong way
> They do:
> resultSpec.containsType("org.apache.uima.tutorial.TimeAnnot")
> which checks the type for language x-unspecified
> But the annotator only works for "en" as mentioned in the output spec so they have to do a check like:
> resultSpec.containsType("org.apache.uima.tutorial.TimeAnnot","en")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (UIMA-891) uima example annotator does not work with the new Result spec design

Posted by "Michael Baessler (JIRA)" <ui...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/UIMA-891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Baessler closed UIMA-891.
---------------------------------

    Resolution: Fixed

> uima example annotator does not work with the new Result spec design
> --------------------------------------------------------------------
>
>                 Key: UIMA-891
>                 URL: https://issues.apache.org/jira/browse/UIMA-891
>             Project: UIMA
>          Issue Type: Bug
>          Components: Examples
>    Affects Versions: 2.2.1
>            Reporter: Michael Baessler
>            Assignee: Michael Baessler
>             Fix For: 2.2.2
>
>
> Annotators does not produce any output result since the use the ResultSpec API in a wrong way
> They do:
> resultSpec.containsType("org.apache.uima.tutorial.TimeAnnot")
> which checks the type for language x-unspecified
> But the annotator only works for "en" as mentioned in the output spec so they have to do a check like:
> resultSpec.containsType("org.apache.uima.tutorial.TimeAnnot","en")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (UIMA-891) uima example annotator does not work with the new Result spec design

Posted by "Marshall Schor (JIRA)" <ui...@incubator.apache.org>.
    [ https://issues.apache.org/jira/browse/UIMA-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12578011#action_12578011 ] 

Marshall Schor commented on UIMA-891:
-------------------------------------

If you do resultSpec.containsType(sometype,  "en-uk")   - in other words, the query is whether the result spec has a type with the language "English" as spoken in the "UK", then the logic for matching give a match when the result spec has this type for the languages "en-uk", "en", or "x-unspecified".   So your last example is correct, above.  

(Maybe you can add a test case to be sure :-) )

The comment in the code that does the language matching in ResultSpecification_impl is:

   * Languages matches if the query language is xxx-yyy and
   *    result spec languages contains:
   *       x-unspecified
   *       xxx-yyy
   *       xxx  

So - you can query with a "sub-language" of what's in the result spec, but not the other way around.


> uima example annotator does not work with the new Result spec design
> --------------------------------------------------------------------
>
>                 Key: UIMA-891
>                 URL: https://issues.apache.org/jira/browse/UIMA-891
>             Project: UIMA
>          Issue Type: Bug
>          Components: Examples
>    Affects Versions: 2.2.1
>            Reporter: Michael Baessler
>            Assignee: Michael Baessler
>             Fix For: 2.2.2
>
>
> Annotators does not produce any output result since the use the ResultSpec API in a wrong way
> They do:
> resultSpec.containsType("org.apache.uima.tutorial.TimeAnnot")
> which checks the type for language x-unspecified
> But the annotator only works for "en" as mentioned in the output spec so they have to do a check like:
> resultSpec.containsType("org.apache.uima.tutorial.TimeAnnot","en")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (UIMA-891) uima example annotator does not work with the new Result spec design

Posted by "Michael Baessler (JIRA)" <ui...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/UIMA-891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Baessler closed UIMA-891.
---------------------------------

    Resolution: Fixed

> uima example annotator does not work with the new Result spec design
> --------------------------------------------------------------------
>
>                 Key: UIMA-891
>                 URL: https://issues.apache.org/jira/browse/UIMA-891
>             Project: UIMA
>          Issue Type: Bug
>          Components: Examples
>    Affects Versions: 2.2.1
>            Reporter: Michael Baessler
>            Assignee: Michael Baessler
>             Fix For: 2.2.2
>
>
> Annotators does not produce any output result since the use the ResultSpec API in a wrong way
> They do:
> resultSpec.containsType("org.apache.uima.tutorial.TimeAnnot")
> which checks the type for language x-unspecified
> But the annotator only works for "en" as mentioned in the output spec so they have to do a check like:
> resultSpec.containsType("org.apache.uima.tutorial.TimeAnnot","en")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (UIMA-891) uima example annotator does not work with the new Result spec design

Posted by "Michael Baessler (JIRA)" <ui...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/UIMA-891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Baessler reopened UIMA-891:
-----------------------------------


found some other places, that has the same issue

> uima example annotator does not work with the new Result spec design
> --------------------------------------------------------------------
>
>                 Key: UIMA-891
>                 URL: https://issues.apache.org/jira/browse/UIMA-891
>             Project: UIMA
>          Issue Type: Bug
>          Components: Examples
>    Affects Versions: 2.2.1
>            Reporter: Michael Baessler
>            Assignee: Michael Baessler
>             Fix For: 2.2.2
>
>
> Annotators does not produce any output result since the use the ResultSpec API in a wrong way
> They do:
> resultSpec.containsType("org.apache.uima.tutorial.TimeAnnot")
> which checks the type for language x-unspecified
> But the annotator only works for "en" as mentioned in the output spec so they have to do a check like:
> resultSpec.containsType("org.apache.uima.tutorial.TimeAnnot","en")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (UIMA-891) uima example annotator does not work with the new Result spec design

Posted by "Michael Baessler (JIRA)" <ui...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/UIMA-891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Baessler resolved UIMA-891.
-----------------------------------

    Resolution: Fixed

> uima example annotator does not work with the new Result spec design
> --------------------------------------------------------------------
>
>                 Key: UIMA-891
>                 URL: https://issues.apache.org/jira/browse/UIMA-891
>             Project: UIMA
>          Issue Type: Bug
>          Components: Examples
>    Affects Versions: 2.2.1
>            Reporter: Michael Baessler
>            Assignee: Michael Baessler
>             Fix For: 2.2.2
>
>
> Annotators does not produce any output result since the use the ResultSpec API in a wrong way
> They do:
> resultSpec.containsType("org.apache.uima.tutorial.TimeAnnot")
> which checks the type for language x-unspecified
> But the annotator only works for "en" as mentioned in the output spec so they have to do a check like:
> resultSpec.containsType("org.apache.uima.tutorial.TimeAnnot","en")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (UIMA-891) uima example annotator does not work with the new Result spec design

Posted by "Michael Baessler (JIRA)" <ui...@incubator.apache.org>.
    [ https://issues.apache.org/jira/browse/UIMA-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12578699#action_12578699 ] 

Michael Baessler commented on UIMA-891:
---------------------------------------

public void testContainsTypeWithLanguage() does the testing mentioned above.

> uima example annotator does not work with the new Result spec design
> --------------------------------------------------------------------
>
>                 Key: UIMA-891
>                 URL: https://issues.apache.org/jira/browse/UIMA-891
>             Project: UIMA
>          Issue Type: Bug
>          Components: Examples
>    Affects Versions: 2.2.1
>            Reporter: Michael Baessler
>            Assignee: Michael Baessler
>             Fix For: 2.2.2
>
>
> Annotators does not produce any output result since the use the ResultSpec API in a wrong way
> They do:
> resultSpec.containsType("org.apache.uima.tutorial.TimeAnnot")
> which checks the type for language x-unspecified
> But the annotator only works for "en" as mentioned in the output spec so they have to do a check like:
> resultSpec.containsType("org.apache.uima.tutorial.TimeAnnot","en")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.