You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by Rakesh R <ra...@intel.com> on 2016/10/05 04:08:48 UTC

Re: Review Request 47354: ZOOKEEPER-1045 : Quorum mutual authentication using SASL mechanism

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47354/
-----------------------------------------------------------

(Updated Oct. 5, 2016, 4:08 a.m.)


Review request for zookeeper, fpj, Ivan Kelly, Patrick Hunt, and Raul Gutierrez Segales.


Changes
-------

Uploading new patch to address Michael's review comments.


Bugs: ZOOKEEPER-1045
    https://issues.apache.org/jira/browse/ZOOKEEPER-1045


Repository: zookeeper-git


Description
-------

Quorum mutual authentication using SASL mechanism - Digest/Kerberos


Diffs
-----

  build.xml ee6834c 
  ivy.xml 95b0e5a 
  src/java/main/org/apache/zookeeper/Login.java aaa220c 
  src/java/main/org/apache/zookeeper/SaslClientCallbackHandler.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/client/ZooKeeperSaslClient.java 21ef0fa 
  src/java/main/org/apache/zookeeper/server/ZooKeeperSaslServer.java 71870ce 
  src/java/main/org/apache/zookeeper/server/auth/SaslServerCallbackHandler.java 2fbd6ed 
  src/java/main/org/apache/zookeeper/server/quorum/Leader.java c83d352 
  src/java/main/org/apache/zookeeper/server/quorum/Learner.java 647b8a2 
  src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java 8a748c7 
  src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java 20e5f16 
  src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 2f0f21b 
  src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java 0924ef6 
  src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java e9c8007 
  src/java/main/org/apache/zookeeper/server/quorum/auth/NullQuorumAuthLearner.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/NullQuorumAuthServer.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/QuorumAuth.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/QuorumAuthLearner.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/QuorumAuthServer.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/README.md PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthLearner.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthServer.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumServerCallbackHandler.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/util/SecurityUtils.java PRE-CREATION 
  src/java/test/data/kerberos/minikdc-krb5.conf PRE-CREATION 
  src/java/test/data/kerberos/minikdc.ldiff PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/CnxManagerTest.java 8db7fa8 
  src/java/test/org/apache/zookeeper/server/quorum/FLEBackwardElectionRoundTest.java c1259d1 
  src/java/test/org/apache/zookeeper/server/quorum/FLECompatibilityTest.java 72e4fc9 
  src/java/test/org/apache/zookeeper/server/quorum/FLEDontCareTest.java a4c0cb0 
  src/java/test/org/apache/zookeeper/server/quorum/FLELostMessageTest.java 39a53ca 
  src/java/test/org/apache/zookeeper/server/quorum/LearnerTest.java 2ae57ce 
  src/java/test/org/apache/zookeeper/server/quorum/QuorumCnxManagerTest.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java 85817b2 
  src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java ab8ce42 
  src/java/test/org/apache/zookeeper/server/quorum/auth/KerberosSecurityTestcase.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/KerberosTestUtils.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/MiniKdc.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/MiniKdcTest.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumAuthTestBase.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumAuthUpgradeTest.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumDigestAuthTest.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumKerberosAuthTest.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumKerberosHostBasedAuthTest.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/test/FLEPredicateTest.java 8088505 
  src/zookeeper.jute 6521e54 

Diff: https://reviews.apache.org/r/47354/diff/


Testing
-------

Added unit test cases to verify the changes.


File Attachments (updated)
----------------

New patch addressing Michael's review comments
  https://reviews.apache.org/media/uploaded/files/2016/10/05/4dd9ed9a-817b-420b-bc6e-b638f6eaa7d9__ZOOKEEPER-1045-br-3-4-authz.patch


Thanks,

Rakesh R


Re: Review Request 47354: ZOOKEEPER-1045 : Quorum mutual authentication using SASL mechanism

Posted by Michael Han <ha...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47354/#review151536
-----------------------------------------------------------


Ship it!




Thanks Rakesh, latest patch looks great to me.

- Michael Han


On Oct. 5, 2016, 4:14 a.m., Rakesh R wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47354/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2016, 4:14 a.m.)
> 
> 
> Review request for zookeeper, fpj, Ivan Kelly, Patrick Hunt, and Raul Gutierrez Segales.
> 
> 
> Bugs: ZOOKEEPER-1045
>     https://issues.apache.org/jira/browse/ZOOKEEPER-1045
> 
> 
> Repository: zookeeper-git
> 
> 
> Description
> -------
> 
> Quorum mutual authentication using SASL mechanism - Digest/Kerberos
> 
> 
> Diffs
> -----
> 
>   build.xml ee6834c 
>   ivy.xml 95b0e5a 
>   src/java/main/org/apache/zookeeper/Login.java aaa220c 
>   src/java/main/org/apache/zookeeper/SaslClientCallbackHandler.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/client/ZooKeeperSaslClient.java 21ef0fa 
>   src/java/main/org/apache/zookeeper/server/ZooKeeperSaslServer.java 71870ce 
>   src/java/main/org/apache/zookeeper/server/auth/SaslServerCallbackHandler.java 2fbd6ed 
>   src/java/main/org/apache/zookeeper/server/quorum/Leader.java c83d352 
>   src/java/main/org/apache/zookeeper/server/quorum/Learner.java 647b8a2 
>   src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java 8a748c7 
>   src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java 20e5f16 
>   src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 2f0f21b 
>   src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java 0924ef6 
>   src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java e9c8007 
>   src/java/main/org/apache/zookeeper/server/quorum/auth/NullQuorumAuthLearner.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/quorum/auth/NullQuorumAuthServer.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/quorum/auth/QuorumAuth.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/quorum/auth/QuorumAuthLearner.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/quorum/auth/QuorumAuthServer.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/quorum/auth/README.md PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthLearner.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthServer.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumServerCallbackHandler.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/util/SecurityUtils.java PRE-CREATION 
>   src/java/test/data/kerberos/minikdc-krb5.conf PRE-CREATION 
>   src/java/test/data/kerberos/minikdc.ldiff PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/CnxManagerTest.java 8db7fa8 
>   src/java/test/org/apache/zookeeper/server/quorum/FLEBackwardElectionRoundTest.java c1259d1 
>   src/java/test/org/apache/zookeeper/server/quorum/FLECompatibilityTest.java 72e4fc9 
>   src/java/test/org/apache/zookeeper/server/quorum/FLEDontCareTest.java a4c0cb0 
>   src/java/test/org/apache/zookeeper/server/quorum/FLELostMessageTest.java 39a53ca 
>   src/java/test/org/apache/zookeeper/server/quorum/LearnerTest.java 2ae57ce 
>   src/java/test/org/apache/zookeeper/server/quorum/QuorumCnxManagerTest.java PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java 85817b2 
>   src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java ab8ce42 
>   src/java/test/org/apache/zookeeper/server/quorum/auth/KerberosSecurityTestcase.java PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/auth/KerberosTestUtils.java PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/auth/MiniKdc.java PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/auth/MiniKdcTest.java PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumAuthTestBase.java PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumAuthUpgradeTest.java PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumDigestAuthTest.java PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumKerberosAuthTest.java PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumKerberosHostBasedAuthTest.java PRE-CREATION 
>   src/java/test/org/apache/zookeeper/test/FLEPredicateTest.java 8088505 
>   src/zookeeper.jute 6521e54 
> 
> Diff: https://reviews.apache.org/r/47354/diff/
> 
> 
> Testing
> -------
> 
> Added unit test cases to verify the changes.
> 
> 
> Thanks,
> 
> Rakesh R
> 
>


Re: Review Request 47354: ZOOKEEPER-1045 : Quorum mutual authentication using SASL mechanism

Posted by Rakesh R <ra...@intel.com>.

> On Nov. 29, 2016, 5:16 p.m., Patrick Hunt wrote:
> > src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java, line 449
> > <https://reviews.apache.org/r/47354/diff/12-13/?file=1560426#file1560426line449>
> >
> >     Doesn't this change change the semantics of SID?

oops...I'm really sorry, I tested with 'observerCounter.getAndDecrement()' but prepared patch wrongly. I will change this to 'observerCounter.getAndDecrement()' soon. In that way, it will be same as existing behavior.


- Rakesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47354/#review157277
-----------------------------------------------------------


On Nov. 25, 2016, 7:28 a.m., Rakesh R wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47354/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2016, 7:28 a.m.)
> 
> 
> Review request for zookeeper, fpj, Ivan Kelly, Patrick Hunt, and Raul Gutierrez Segales.
> 
> 
> Bugs: ZOOKEEPER-1045
>     https://issues.apache.org/jira/browse/ZOOKEEPER-1045
> 
> 
> Repository: zookeeper-git
> 
> 
> Description
> -------
> 
> Quorum mutual authentication using SASL mechanism - Digest/Kerberos
> 
> 
> Diffs
> -----
> 
>   build.xml 505597a 
>   ivy.xml 95b0e5a 
>   src/java/main/org/apache/zookeeper/Login.java aaa220c 
>   src/java/main/org/apache/zookeeper/SaslClientCallbackHandler.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/client/ZooKeeperSaslClient.java 21ef0fa 
>   src/java/main/org/apache/zookeeper/server/ZooKeeperSaslServer.java 71870ce 
>   src/java/main/org/apache/zookeeper/server/auth/SaslServerCallbackHandler.java 7fdffde 
>   src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java 78f3aa6 
>   src/java/main/org/apache/zookeeper/server/quorum/Follower.java 043a522 
>   src/java/main/org/apache/zookeeper/server/quorum/Leader.java c83d352 
>   src/java/main/org/apache/zookeeper/server/quorum/Learner.java 647b8a2 
>   src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java 8a748c7 
>   src/java/main/org/apache/zookeeper/server/quorum/Observer.java e53f6f2 
>   src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java 20e5f16 
>   src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 2f0f21b 
>   src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java 0924ef6 
>   src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java e9c8007 
>   src/java/main/org/apache/zookeeper/server/quorum/auth/NullQuorumAuthLearner.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/quorum/auth/NullQuorumAuthServer.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/quorum/auth/QuorumAuth.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/quorum/auth/QuorumAuthLearner.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/quorum/auth/QuorumAuthServer.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthLearner.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthServer.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumServerCallbackHandler.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/util/SecurityUtils.java PRE-CREATION 
>   src/java/test/data/kerberos/minikdc-krb5.conf PRE-CREATION 
>   src/java/test/data/kerberos/minikdc.ldiff PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/CnxManagerTest.java 8db7fa8 
>   src/java/test/org/apache/zookeeper/server/quorum/FLEBackwardElectionRoundTest.java c1259d1 
>   src/java/test/org/apache/zookeeper/server/quorum/FLECompatibilityTest.java 72e4fc9 
>   src/java/test/org/apache/zookeeper/server/quorum/FLEDontCareTest.java a4c0cb0 
>   src/java/test/org/apache/zookeeper/server/quorum/FLELostMessageTest.java 39a53ca 
>   src/java/test/org/apache/zookeeper/server/quorum/LearnerTest.java 2ae57ce 
>   src/java/test/org/apache/zookeeper/server/quorum/QuorumCnxManagerTest.java PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java 85817b2 
>   src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java ab8ce42 
>   src/java/test/org/apache/zookeeper/server/quorum/auth/KerberosSecurityTestcase.java PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/auth/KerberosTestUtils.java PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/auth/MiniKdc.java PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/auth/MiniKdcTest.java PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumAuthTestBase.java PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumAuthUpgradeTest.java PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumDigestAuthTest.java PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumKerberosAuthTest.java PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumKerberosHostBasedAuthTest.java PRE-CREATION 
>   src/java/test/org/apache/zookeeper/test/FLEPredicateTest.java 8088505 
>   src/zookeeper.jute 6521e54 
> 
> Diff: https://reviews.apache.org/r/47354/diff/
> 
> 
> Testing
> -------
> 
> Added unit test cases to verify the changes.
> 
> 
> Thanks,
> 
> Rakesh R
> 
>


Re: Review Request 47354: ZOOKEEPER-1045 : Quorum mutual authentication using SASL mechanism

Posted by Patrick Hunt <ph...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47354/#review157277
-----------------------------------------------------------




src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java (line 449)
<https://reviews.apache.org/r/47354/#comment227801>

    Doesn't this change change the semantics of SID?


- Patrick Hunt


On Nov. 25, 2016, 7:28 a.m., Rakesh R wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47354/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2016, 7:28 a.m.)
> 
> 
> Review request for zookeeper, fpj, Ivan Kelly, Patrick Hunt, and Raul Gutierrez Segales.
> 
> 
> Bugs: ZOOKEEPER-1045
>     https://issues.apache.org/jira/browse/ZOOKEEPER-1045
> 
> 
> Repository: zookeeper-git
> 
> 
> Description
> -------
> 
> Quorum mutual authentication using SASL mechanism - Digest/Kerberos
> 
> 
> Diffs
> -----
> 
>   build.xml 505597a 
>   ivy.xml 95b0e5a 
>   src/java/main/org/apache/zookeeper/Login.java aaa220c 
>   src/java/main/org/apache/zookeeper/SaslClientCallbackHandler.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/client/ZooKeeperSaslClient.java 21ef0fa 
>   src/java/main/org/apache/zookeeper/server/ZooKeeperSaslServer.java 71870ce 
>   src/java/main/org/apache/zookeeper/server/auth/SaslServerCallbackHandler.java 7fdffde 
>   src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java 78f3aa6 
>   src/java/main/org/apache/zookeeper/server/quorum/Follower.java 043a522 
>   src/java/main/org/apache/zookeeper/server/quorum/Leader.java c83d352 
>   src/java/main/org/apache/zookeeper/server/quorum/Learner.java 647b8a2 
>   src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java 8a748c7 
>   src/java/main/org/apache/zookeeper/server/quorum/Observer.java e53f6f2 
>   src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java 20e5f16 
>   src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 2f0f21b 
>   src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java 0924ef6 
>   src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java e9c8007 
>   src/java/main/org/apache/zookeeper/server/quorum/auth/NullQuorumAuthLearner.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/quorum/auth/NullQuorumAuthServer.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/quorum/auth/QuorumAuth.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/quorum/auth/QuorumAuthLearner.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/quorum/auth/QuorumAuthServer.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthLearner.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthServer.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumServerCallbackHandler.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/util/SecurityUtils.java PRE-CREATION 
>   src/java/test/data/kerberos/minikdc-krb5.conf PRE-CREATION 
>   src/java/test/data/kerberos/minikdc.ldiff PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/CnxManagerTest.java 8db7fa8 
>   src/java/test/org/apache/zookeeper/server/quorum/FLEBackwardElectionRoundTest.java c1259d1 
>   src/java/test/org/apache/zookeeper/server/quorum/FLECompatibilityTest.java 72e4fc9 
>   src/java/test/org/apache/zookeeper/server/quorum/FLEDontCareTest.java a4c0cb0 
>   src/java/test/org/apache/zookeeper/server/quorum/FLELostMessageTest.java 39a53ca 
>   src/java/test/org/apache/zookeeper/server/quorum/LearnerTest.java 2ae57ce 
>   src/java/test/org/apache/zookeeper/server/quorum/QuorumCnxManagerTest.java PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java 85817b2 
>   src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java ab8ce42 
>   src/java/test/org/apache/zookeeper/server/quorum/auth/KerberosSecurityTestcase.java PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/auth/KerberosTestUtils.java PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/auth/MiniKdc.java PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/auth/MiniKdcTest.java PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumAuthTestBase.java PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumAuthUpgradeTest.java PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumDigestAuthTest.java PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumKerberosAuthTest.java PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumKerberosHostBasedAuthTest.java PRE-CREATION 
>   src/java/test/org/apache/zookeeper/test/FLEPredicateTest.java 8088505 
>   src/zookeeper.jute 6521e54 
> 
> Diff: https://reviews.apache.org/r/47354/diff/
> 
> 
> Testing
> -------
> 
> Added unit test cases to verify the changes.
> 
> 
> Thanks,
> 
> Rakesh R
> 
>


Re: Review Request 47354: ZOOKEEPER-1045 : Quorum mutual authentication using SASL mechanism

Posted by Patrick Hunt <ph...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47354/#review158075
-----------------------------------------------------------


Ship it!




Latest patch looks good to me - the recent change addresses my remaining issues. I'm +1.

- Patrick Hunt


On Nov. 29, 2016, 6:26 p.m., Rakesh R wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47354/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2016, 6:26 p.m.)
> 
> 
> Review request for zookeeper, fpj, Ivan Kelly, Patrick Hunt, and Raul Gutierrez Segales.
> 
> 
> Bugs: ZOOKEEPER-1045
>     https://issues.apache.org/jira/browse/ZOOKEEPER-1045
> 
> 
> Repository: zookeeper-git
> 
> 
> Description
> -------
> 
> Quorum mutual authentication using SASL mechanism - Digest/Kerberos
> 
> 
> Diffs
> -----
> 
>   build.xml 505597a 
>   ivy.xml 95b0e5a 
>   src/java/main/org/apache/zookeeper/Login.java aaa220c 
>   src/java/main/org/apache/zookeeper/SaslClientCallbackHandler.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/client/ZooKeeperSaslClient.java 21ef0fa 
>   src/java/main/org/apache/zookeeper/server/ZooKeeperSaslServer.java 71870ce 
>   src/java/main/org/apache/zookeeper/server/auth/SaslServerCallbackHandler.java 7fdffde 
>   src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java 78f3aa6 
>   src/java/main/org/apache/zookeeper/server/quorum/Follower.java 043a522 
>   src/java/main/org/apache/zookeeper/server/quorum/Leader.java c83d352 
>   src/java/main/org/apache/zookeeper/server/quorum/Learner.java 647b8a2 
>   src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java 8a748c7 
>   src/java/main/org/apache/zookeeper/server/quorum/Observer.java e53f6f2 
>   src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java 20e5f16 
>   src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 2f0f21b 
>   src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java 0924ef6 
>   src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java e9c8007 
>   src/java/main/org/apache/zookeeper/server/quorum/auth/NullQuorumAuthLearner.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/quorum/auth/NullQuorumAuthServer.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/quorum/auth/QuorumAuth.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/quorum/auth/QuorumAuthLearner.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/quorum/auth/QuorumAuthServer.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthLearner.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthServer.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumServerCallbackHandler.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/util/SecurityUtils.java PRE-CREATION 
>   src/java/test/data/kerberos/minikdc-krb5.conf PRE-CREATION 
>   src/java/test/data/kerberos/minikdc.ldiff PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/CnxManagerTest.java 8db7fa8 
>   src/java/test/org/apache/zookeeper/server/quorum/FLEBackwardElectionRoundTest.java c1259d1 
>   src/java/test/org/apache/zookeeper/server/quorum/FLECompatibilityTest.java 72e4fc9 
>   src/java/test/org/apache/zookeeper/server/quorum/FLEDontCareTest.java a4c0cb0 
>   src/java/test/org/apache/zookeeper/server/quorum/FLELostMessageTest.java 39a53ca 
>   src/java/test/org/apache/zookeeper/server/quorum/LearnerTest.java 2ae57ce 
>   src/java/test/org/apache/zookeeper/server/quorum/QuorumCnxManagerTest.java PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java 85817b2 
>   src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java ab8ce42 
>   src/java/test/org/apache/zookeeper/server/quorum/auth/KerberosSecurityTestcase.java PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/auth/KerberosTestUtils.java PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/auth/MiniKdc.java PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/auth/MiniKdcTest.java PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumAuthTestBase.java PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumAuthUpgradeTest.java PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumDigestAuthTest.java PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumKerberosAuthTest.java PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumKerberosHostBasedAuthTest.java PRE-CREATION 
>   src/java/test/org/apache/zookeeper/test/FLEPredicateTest.java 8088505 
>   src/zookeeper.jute 6521e54 
> 
> Diff: https://reviews.apache.org/r/47354/diff/
> 
> 
> Testing
> -------
> 
> Added unit test cases to verify the changes.
> 
> 
> Thanks,
> 
> Rakesh R
> 
>


Re: Review Request 47354: ZOOKEEPER-1045 : Quorum mutual authentication using SASL mechanism

Posted by Rakesh R <ra...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47354/
-----------------------------------------------------------

(Updated Nov. 29, 2016, 6:26 p.m.)


Review request for zookeeper, fpj, Ivan Kelly, Patrick Hunt, and Raul Gutierrez Segales.


Changes
-------

Attached new patch addressing Pat Hunt's comment.


Bugs: ZOOKEEPER-1045
    https://issues.apache.org/jira/browse/ZOOKEEPER-1045


Repository: zookeeper-git


Description
-------

Quorum mutual authentication using SASL mechanism - Digest/Kerberos


Diffs (updated)
-----

  build.xml 505597a 
  ivy.xml 95b0e5a 
  src/java/main/org/apache/zookeeper/Login.java aaa220c 
  src/java/main/org/apache/zookeeper/SaslClientCallbackHandler.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/client/ZooKeeperSaslClient.java 21ef0fa 
  src/java/main/org/apache/zookeeper/server/ZooKeeperSaslServer.java 71870ce 
  src/java/main/org/apache/zookeeper/server/auth/SaslServerCallbackHandler.java 7fdffde 
  src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java 78f3aa6 
  src/java/main/org/apache/zookeeper/server/quorum/Follower.java 043a522 
  src/java/main/org/apache/zookeeper/server/quorum/Leader.java c83d352 
  src/java/main/org/apache/zookeeper/server/quorum/Learner.java 647b8a2 
  src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java 8a748c7 
  src/java/main/org/apache/zookeeper/server/quorum/Observer.java e53f6f2 
  src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java 20e5f16 
  src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 2f0f21b 
  src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java 0924ef6 
  src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java e9c8007 
  src/java/main/org/apache/zookeeper/server/quorum/auth/NullQuorumAuthLearner.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/NullQuorumAuthServer.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/QuorumAuth.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/QuorumAuthLearner.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/QuorumAuthServer.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthLearner.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthServer.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumServerCallbackHandler.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/util/SecurityUtils.java PRE-CREATION 
  src/java/test/data/kerberos/minikdc-krb5.conf PRE-CREATION 
  src/java/test/data/kerberos/minikdc.ldiff PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/CnxManagerTest.java 8db7fa8 
  src/java/test/org/apache/zookeeper/server/quorum/FLEBackwardElectionRoundTest.java c1259d1 
  src/java/test/org/apache/zookeeper/server/quorum/FLECompatibilityTest.java 72e4fc9 
  src/java/test/org/apache/zookeeper/server/quorum/FLEDontCareTest.java a4c0cb0 
  src/java/test/org/apache/zookeeper/server/quorum/FLELostMessageTest.java 39a53ca 
  src/java/test/org/apache/zookeeper/server/quorum/LearnerTest.java 2ae57ce 
  src/java/test/org/apache/zookeeper/server/quorum/QuorumCnxManagerTest.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java 85817b2 
  src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java ab8ce42 
  src/java/test/org/apache/zookeeper/server/quorum/auth/KerberosSecurityTestcase.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/KerberosTestUtils.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/MiniKdc.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/MiniKdcTest.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumAuthTestBase.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumAuthUpgradeTest.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumDigestAuthTest.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumKerberosAuthTest.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumKerberosHostBasedAuthTest.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/test/FLEPredicateTest.java 8088505 
  src/zookeeper.jute 6521e54 

Diff: https://reviews.apache.org/r/47354/diff/


Testing
-------

Added unit test cases to verify the changes.


Thanks,

Rakesh R


Re: Review Request 47354: ZOOKEEPER-1045 : Quorum mutual authentication using SASL mechanism

Posted by Rakesh R <ra...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47354/
-----------------------------------------------------------

(Updated Nov. 25, 2016, 7:28 a.m.)


Review request for zookeeper, fpj, Ivan Kelly, Patrick Hunt, and Raul Gutierrez Segales.


Changes
-------

New patch addressing Pat Hunt's review comments. Following changes:
    - Used AtomicInteger for observerCounter.
    - Added counter to count connection processing threads. Now, I've added log messages in each LE iteration. Later if requires can expose bean attribute. 
      Also, I hope this will be helpful to tune the configuration property "quorum.cnxn.threads.size"


Bugs: ZOOKEEPER-1045
    https://issues.apache.org/jira/browse/ZOOKEEPER-1045


Repository: zookeeper-git


Description
-------

Quorum mutual authentication using SASL mechanism - Digest/Kerberos


Diffs (updated)
-----

  build.xml 505597a 
  ivy.xml 95b0e5a 
  src/java/main/org/apache/zookeeper/Login.java aaa220c 
  src/java/main/org/apache/zookeeper/SaslClientCallbackHandler.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/client/ZooKeeperSaslClient.java 21ef0fa 
  src/java/main/org/apache/zookeeper/server/ZooKeeperSaslServer.java 71870ce 
  src/java/main/org/apache/zookeeper/server/auth/SaslServerCallbackHandler.java 7fdffde 
  src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java 78f3aa6 
  src/java/main/org/apache/zookeeper/server/quorum/Follower.java 043a522 
  src/java/main/org/apache/zookeeper/server/quorum/Leader.java c83d352 
  src/java/main/org/apache/zookeeper/server/quorum/Learner.java 647b8a2 
  src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java 8a748c7 
  src/java/main/org/apache/zookeeper/server/quorum/Observer.java e53f6f2 
  src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java 20e5f16 
  src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 2f0f21b 
  src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java 0924ef6 
  src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java e9c8007 
  src/java/main/org/apache/zookeeper/server/quorum/auth/NullQuorumAuthLearner.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/NullQuorumAuthServer.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/QuorumAuth.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/QuorumAuthLearner.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/QuorumAuthServer.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthLearner.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthServer.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumServerCallbackHandler.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/util/SecurityUtils.java PRE-CREATION 
  src/java/test/data/kerberos/minikdc-krb5.conf PRE-CREATION 
  src/java/test/data/kerberos/minikdc.ldiff PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/CnxManagerTest.java 8db7fa8 
  src/java/test/org/apache/zookeeper/server/quorum/FLEBackwardElectionRoundTest.java c1259d1 
  src/java/test/org/apache/zookeeper/server/quorum/FLECompatibilityTest.java 72e4fc9 
  src/java/test/org/apache/zookeeper/server/quorum/FLEDontCareTest.java a4c0cb0 
  src/java/test/org/apache/zookeeper/server/quorum/FLELostMessageTest.java 39a53ca 
  src/java/test/org/apache/zookeeper/server/quorum/LearnerTest.java 2ae57ce 
  src/java/test/org/apache/zookeeper/server/quorum/QuorumCnxManagerTest.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java 85817b2 
  src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java ab8ce42 
  src/java/test/org/apache/zookeeper/server/quorum/auth/KerberosSecurityTestcase.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/KerberosTestUtils.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/MiniKdc.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/MiniKdcTest.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumAuthTestBase.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumAuthUpgradeTest.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumDigestAuthTest.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumKerberosAuthTest.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumKerberosHostBasedAuthTest.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/test/FLEPredicateTest.java 8088505 
  src/zookeeper.jute 6521e54 

Diff: https://reviews.apache.org/r/47354/diff/


Testing
-------

Added unit test cases to verify the changes.


Thanks,

Rakesh R


Re: Review Request 47354: ZOOKEEPER-1045 : Quorum mutual authentication using SASL mechanism

Posted by Rakesh R <ra...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47354/
-----------------------------------------------------------

(Updated Nov. 10, 2016, 3:38 p.m.)


Review request for zookeeper, fpj, Ivan Kelly, Patrick Hunt, and Raul Gutierrez Segales.


Changes
-------

Attached new patch fixing Eugene Koontz's comments.


Bugs: ZOOKEEPER-1045
    https://issues.apache.org/jira/browse/ZOOKEEPER-1045


Repository: zookeeper-git


Description
-------

Quorum mutual authentication using SASL mechanism - Digest/Kerberos


Diffs (updated)
-----

  build.xml 505597a 
  ivy.xml 95b0e5a 
  src/java/main/org/apache/zookeeper/Login.java aaa220c 
  src/java/main/org/apache/zookeeper/SaslClientCallbackHandler.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/client/ZooKeeperSaslClient.java 21ef0fa 
  src/java/main/org/apache/zookeeper/server/ZooKeeperSaslServer.java 71870ce 
  src/java/main/org/apache/zookeeper/server/auth/SaslServerCallbackHandler.java 7fdffde 
  src/java/main/org/apache/zookeeper/server/quorum/Follower.java 043a522 
  src/java/main/org/apache/zookeeper/server/quorum/Leader.java c83d352 
  src/java/main/org/apache/zookeeper/server/quorum/Learner.java 647b8a2 
  src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java 8a748c7 
  src/java/main/org/apache/zookeeper/server/quorum/Observer.java e53f6f2 
  src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java 20e5f16 
  src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 2f0f21b 
  src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java 0924ef6 
  src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java e9c8007 
  src/java/main/org/apache/zookeeper/server/quorum/auth/NullQuorumAuthLearner.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/NullQuorumAuthServer.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/QuorumAuth.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/QuorumAuthLearner.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/QuorumAuthServer.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthLearner.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthServer.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumServerCallbackHandler.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/util/SecurityUtils.java PRE-CREATION 
  src/java/test/data/kerberos/minikdc-krb5.conf PRE-CREATION 
  src/java/test/data/kerberos/minikdc.ldiff PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/CnxManagerTest.java 8db7fa8 
  src/java/test/org/apache/zookeeper/server/quorum/FLEBackwardElectionRoundTest.java c1259d1 
  src/java/test/org/apache/zookeeper/server/quorum/FLECompatibilityTest.java 72e4fc9 
  src/java/test/org/apache/zookeeper/server/quorum/FLEDontCareTest.java a4c0cb0 
  src/java/test/org/apache/zookeeper/server/quorum/FLELostMessageTest.java 39a53ca 
  src/java/test/org/apache/zookeeper/server/quorum/LearnerTest.java 2ae57ce 
  src/java/test/org/apache/zookeeper/server/quorum/QuorumCnxManagerTest.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java 85817b2 
  src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java ab8ce42 
  src/java/test/org/apache/zookeeper/server/quorum/auth/KerberosSecurityTestcase.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/KerberosTestUtils.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/MiniKdc.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/MiniKdcTest.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumAuthTestBase.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumAuthUpgradeTest.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumDigestAuthTest.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumKerberosAuthTest.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumKerberosHostBasedAuthTest.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/test/FLEPredicateTest.java 8088505 
  src/zookeeper.jute 6521e54 

Diff: https://reviews.apache.org/r/47354/diff/


Testing
-------

Added unit test cases to verify the changes.


Thanks,

Rakesh R


Re: Review Request 47354: ZOOKEEPER-1045 : Quorum mutual authentication using SASL mechanism

Posted by Eugene Koontz <ek...@hiro-tan.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47354/#review154205
-----------------------------------------------------------




src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java (line 188)
<https://reviews.apache.org/r/47354/#comment223706>

    typo: should be initializeAuth(..)



src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java (line 189)
<https://reviews.apache.org/r/47354/#comment223707>

    Seems a little strange to call initalizeAuth() if (quorumSaslAuthEnabled == false), but not a big deal.



src/java/test/org/apache/zookeeper/server/quorum/QuorumCnxManagerTest.java (line 693)
<https://reviews.apache.org/r/47354/#comment223708>

    I wonder if it would be clearer to change the variable name from clientLoginContext to learnerLoginContext since the we are always calling createAndStartManager() with the 3rd argument being the string "QuorumLearner"



src/java/test/org/apache/zookeeper/server/quorum/QuorumCnxManagerTest.java (line 695)
<https://reviews.apache.org/r/47354/#comment223709>

    As with last comment, maybe this should be called learnerRequireSasl?


- Eugene Koontz


On Oct. 25, 2016, 5:05 a.m., Rakesh R wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47354/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2016, 5:05 a.m.)
> 
> 
> Review request for zookeeper, fpj, Ivan Kelly, Patrick Hunt, and Raul Gutierrez Segales.
> 
> 
> Bugs: ZOOKEEPER-1045
>     https://issues.apache.org/jira/browse/ZOOKEEPER-1045
> 
> 
> Repository: zookeeper-git
> 
> 
> Description
> -------
> 
> Quorum mutual authentication using SASL mechanism - Digest/Kerberos
> 
> 
> Diffs
> -----
> 
>   build.xml 505597a 
>   ivy.xml 95b0e5a 
>   src/java/main/org/apache/zookeeper/Login.java aaa220c 
>   src/java/main/org/apache/zookeeper/SaslClientCallbackHandler.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/client/ZooKeeperSaslClient.java 21ef0fa 
>   src/java/main/org/apache/zookeeper/server/ZooKeeperSaslServer.java 71870ce 
>   src/java/main/org/apache/zookeeper/server/auth/SaslServerCallbackHandler.java 7fdffde 
>   src/java/main/org/apache/zookeeper/server/quorum/Follower.java 043a522 
>   src/java/main/org/apache/zookeeper/server/quorum/Leader.java c83d352 
>   src/java/main/org/apache/zookeeper/server/quorum/Learner.java 647b8a2 
>   src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java 8a748c7 
>   src/java/main/org/apache/zookeeper/server/quorum/Observer.java e53f6f2 
>   src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java 20e5f16 
>   src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 2f0f21b 
>   src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java 0924ef6 
>   src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java e9c8007 
>   src/java/main/org/apache/zookeeper/server/quorum/auth/NullQuorumAuthLearner.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/quorum/auth/NullQuorumAuthServer.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/quorum/auth/QuorumAuth.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/quorum/auth/QuorumAuthLearner.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/quorum/auth/QuorumAuthServer.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthLearner.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthServer.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumServerCallbackHandler.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/util/SecurityUtils.java PRE-CREATION 
>   src/java/test/data/kerberos/minikdc-krb5.conf PRE-CREATION 
>   src/java/test/data/kerberos/minikdc.ldiff PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/CnxManagerTest.java 8db7fa8 
>   src/java/test/org/apache/zookeeper/server/quorum/FLEBackwardElectionRoundTest.java c1259d1 
>   src/java/test/org/apache/zookeeper/server/quorum/FLECompatibilityTest.java 72e4fc9 
>   src/java/test/org/apache/zookeeper/server/quorum/FLEDontCareTest.java a4c0cb0 
>   src/java/test/org/apache/zookeeper/server/quorum/FLELostMessageTest.java 39a53ca 
>   src/java/test/org/apache/zookeeper/server/quorum/LearnerTest.java 2ae57ce 
>   src/java/test/org/apache/zookeeper/server/quorum/QuorumCnxManagerTest.java PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java 85817b2 
>   src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java ab8ce42 
>   src/java/test/org/apache/zookeeper/server/quorum/auth/KerberosSecurityTestcase.java PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/auth/KerberosTestUtils.java PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/auth/MiniKdc.java PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/auth/MiniKdcTest.java PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumAuthTestBase.java PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumAuthUpgradeTest.java PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumDigestAuthTest.java PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumKerberosAuthTest.java PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumKerberosHostBasedAuthTest.java PRE-CREATION 
>   src/java/test/org/apache/zookeeper/test/FLEPredicateTest.java 8088505 
>   src/zookeeper.jute 6521e54 
> 
> Diff: https://reviews.apache.org/r/47354/diff/
> 
> 
> Testing
> -------
> 
> Added unit test cases to verify the changes.
> 
> 
> Thanks,
> 
> Rakesh R
> 
>


Re: Review Request 47354: ZOOKEEPER-1045 : Quorum mutual authentication using SASL mechanism

Posted by Rakesh R <ra...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47354/
-----------------------------------------------------------

(Updated Oct. 25, 2016, 5:05 a.m.)


Review request for zookeeper, fpj, Ivan Kelly, Patrick Hunt, and Raul Gutierrez Segales.


Changes
-------

New patch contains the following changes:
           Renamed quorumcnxn.threads.size to quorum.cnxn.threads.size
           Removed README.md from the patch as I attached feature doc pdf doc separately in jira
           Replaced IOUtils.cleanup(LOG, sock) with simple sock.close(); as java-1.6 shows compilation errors.


Bugs: ZOOKEEPER-1045
    https://issues.apache.org/jira/browse/ZOOKEEPER-1045


Repository: zookeeper-git


Description
-------

Quorum mutual authentication using SASL mechanism - Digest/Kerberos


Diffs (updated)
-----

  build.xml 505597a 
  ivy.xml 95b0e5a 
  src/java/main/org/apache/zookeeper/Login.java aaa220c 
  src/java/main/org/apache/zookeeper/SaslClientCallbackHandler.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/client/ZooKeeperSaslClient.java 21ef0fa 
  src/java/main/org/apache/zookeeper/server/ZooKeeperSaslServer.java 71870ce 
  src/java/main/org/apache/zookeeper/server/auth/SaslServerCallbackHandler.java 7fdffde 
  src/java/main/org/apache/zookeeper/server/quorum/Follower.java 043a522 
  src/java/main/org/apache/zookeeper/server/quorum/Leader.java c83d352 
  src/java/main/org/apache/zookeeper/server/quorum/Learner.java 647b8a2 
  src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java 8a748c7 
  src/java/main/org/apache/zookeeper/server/quorum/Observer.java e53f6f2 
  src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java 20e5f16 
  src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 2f0f21b 
  src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java 0924ef6 
  src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java e9c8007 
  src/java/main/org/apache/zookeeper/server/quorum/auth/NullQuorumAuthLearner.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/NullQuorumAuthServer.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/QuorumAuth.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/QuorumAuthLearner.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/QuorumAuthServer.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthLearner.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthServer.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumServerCallbackHandler.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/util/SecurityUtils.java PRE-CREATION 
  src/java/test/data/kerberos/minikdc-krb5.conf PRE-CREATION 
  src/java/test/data/kerberos/minikdc.ldiff PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/CnxManagerTest.java 8db7fa8 
  src/java/test/org/apache/zookeeper/server/quorum/FLEBackwardElectionRoundTest.java c1259d1 
  src/java/test/org/apache/zookeeper/server/quorum/FLECompatibilityTest.java 72e4fc9 
  src/java/test/org/apache/zookeeper/server/quorum/FLEDontCareTest.java a4c0cb0 
  src/java/test/org/apache/zookeeper/server/quorum/FLELostMessageTest.java 39a53ca 
  src/java/test/org/apache/zookeeper/server/quorum/LearnerTest.java 2ae57ce 
  src/java/test/org/apache/zookeeper/server/quorum/QuorumCnxManagerTest.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java 85817b2 
  src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java ab8ce42 
  src/java/test/org/apache/zookeeper/server/quorum/auth/KerberosSecurityTestcase.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/KerberosTestUtils.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/MiniKdc.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/MiniKdcTest.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumAuthTestBase.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumAuthUpgradeTest.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumDigestAuthTest.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumKerberosAuthTest.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumKerberosHostBasedAuthTest.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/test/FLEPredicateTest.java 8088505 
  src/zookeeper.jute 6521e54 

Diff: https://reviews.apache.org/r/47354/diff/


Testing
-------

Added unit test cases to verify the changes.


Thanks,

Rakesh R


Re: Review Request 47354: ZOOKEEPER-1045 : Quorum mutual authentication using SASL mechanism

Posted by Rakesh R <ra...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47354/
-----------------------------------------------------------

(Updated Oct. 5, 2016, 4:14 a.m.)


Review request for zookeeper, fpj, Ivan Kelly, Patrick Hunt, and Raul Gutierrez Segales.


Changes
-------

Uploading new patch to address Michael's review comments. Major change - provided separate code path to execute the auth based connection requests asynchronously and for non-auth requests will be processed in old fashion sequentially.


Bugs: ZOOKEEPER-1045
    https://issues.apache.org/jira/browse/ZOOKEEPER-1045


Repository: zookeeper-git


Description
-------

Quorum mutual authentication using SASL mechanism - Digest/Kerberos


Diffs (updated)
-----

  build.xml ee6834c 
  ivy.xml 95b0e5a 
  src/java/main/org/apache/zookeeper/Login.java aaa220c 
  src/java/main/org/apache/zookeeper/SaslClientCallbackHandler.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/client/ZooKeeperSaslClient.java 21ef0fa 
  src/java/main/org/apache/zookeeper/server/ZooKeeperSaslServer.java 71870ce 
  src/java/main/org/apache/zookeeper/server/auth/SaslServerCallbackHandler.java 2fbd6ed 
  src/java/main/org/apache/zookeeper/server/quorum/Leader.java c83d352 
  src/java/main/org/apache/zookeeper/server/quorum/Learner.java 647b8a2 
  src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java 8a748c7 
  src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java 20e5f16 
  src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 2f0f21b 
  src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java 0924ef6 
  src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java e9c8007 
  src/java/main/org/apache/zookeeper/server/quorum/auth/NullQuorumAuthLearner.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/NullQuorumAuthServer.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/QuorumAuth.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/QuorumAuthLearner.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/QuorumAuthServer.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/README.md PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthLearner.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthServer.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumServerCallbackHandler.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/util/SecurityUtils.java PRE-CREATION 
  src/java/test/data/kerberos/minikdc-krb5.conf PRE-CREATION 
  src/java/test/data/kerberos/minikdc.ldiff PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/CnxManagerTest.java 8db7fa8 
  src/java/test/org/apache/zookeeper/server/quorum/FLEBackwardElectionRoundTest.java c1259d1 
  src/java/test/org/apache/zookeeper/server/quorum/FLECompatibilityTest.java 72e4fc9 
  src/java/test/org/apache/zookeeper/server/quorum/FLEDontCareTest.java a4c0cb0 
  src/java/test/org/apache/zookeeper/server/quorum/FLELostMessageTest.java 39a53ca 
  src/java/test/org/apache/zookeeper/server/quorum/LearnerTest.java 2ae57ce 
  src/java/test/org/apache/zookeeper/server/quorum/QuorumCnxManagerTest.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java 85817b2 
  src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java ab8ce42 
  src/java/test/org/apache/zookeeper/server/quorum/auth/KerberosSecurityTestcase.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/KerberosTestUtils.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/MiniKdc.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/MiniKdcTest.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumAuthTestBase.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumAuthUpgradeTest.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumDigestAuthTest.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumKerberosAuthTest.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumKerberosHostBasedAuthTest.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/test/FLEPredicateTest.java 8088505 
  src/zookeeper.jute 6521e54 

Diff: https://reviews.apache.org/r/47354/diff/


Testing
-------

Added unit test cases to verify the changes.


Thanks,

Rakesh R


Re: Review Request 47354: ZOOKEEPER-1045 : Quorum mutual authentication using SASL mechanism

Posted by Rakesh R <ra...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47354/
-----------------------------------------------------------

(Updated Oct. 5, 2016, 4:10 a.m.)


Review request for zookeeper, fpj, Ivan Kelly, Patrick Hunt, and Raul Gutierrez Segales.


Bugs: ZOOKEEPER-1045
    https://issues.apache.org/jira/browse/ZOOKEEPER-1045


Repository: zookeeper-git


Description
-------

Quorum mutual authentication using SASL mechanism - Digest/Kerberos


Diffs
-----

  build.xml ee6834c 
  ivy.xml 95b0e5a 
  src/java/main/org/apache/zookeeper/Login.java aaa220c 
  src/java/main/org/apache/zookeeper/SaslClientCallbackHandler.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/client/ZooKeeperSaslClient.java 21ef0fa 
  src/java/main/org/apache/zookeeper/server/ZooKeeperSaslServer.java 71870ce 
  src/java/main/org/apache/zookeeper/server/auth/SaslServerCallbackHandler.java 2fbd6ed 
  src/java/main/org/apache/zookeeper/server/quorum/Leader.java c83d352 
  src/java/main/org/apache/zookeeper/server/quorum/Learner.java 647b8a2 
  src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java 8a748c7 
  src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java 20e5f16 
  src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 2f0f21b 
  src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java 0924ef6 
  src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java e9c8007 
  src/java/main/org/apache/zookeeper/server/quorum/auth/NullQuorumAuthLearner.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/NullQuorumAuthServer.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/QuorumAuth.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/QuorumAuthLearner.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/QuorumAuthServer.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/README.md PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthLearner.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthServer.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumServerCallbackHandler.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/util/SecurityUtils.java PRE-CREATION 
  src/java/test/data/kerberos/minikdc-krb5.conf PRE-CREATION 
  src/java/test/data/kerberos/minikdc.ldiff PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/CnxManagerTest.java 8db7fa8 
  src/java/test/org/apache/zookeeper/server/quorum/FLEBackwardElectionRoundTest.java c1259d1 
  src/java/test/org/apache/zookeeper/server/quorum/FLECompatibilityTest.java 72e4fc9 
  src/java/test/org/apache/zookeeper/server/quorum/FLEDontCareTest.java a4c0cb0 
  src/java/test/org/apache/zookeeper/server/quorum/FLELostMessageTest.java 39a53ca 
  src/java/test/org/apache/zookeeper/server/quorum/LearnerTest.java 2ae57ce 
  src/java/test/org/apache/zookeeper/server/quorum/QuorumCnxManagerTest.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java 85817b2 
  src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java ab8ce42 
  src/java/test/org/apache/zookeeper/server/quorum/auth/KerberosSecurityTestcase.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/KerberosTestUtils.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/MiniKdc.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/MiniKdcTest.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumAuthTestBase.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumAuthUpgradeTest.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumDigestAuthTest.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumKerberosAuthTest.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumKerberosHostBasedAuthTest.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/test/FLEPredicateTest.java 8088505 
  src/zookeeper.jute 6521e54 

Diff: https://reviews.apache.org/r/47354/diff/


Testing
-------

Added unit test cases to verify the changes.


Thanks,

Rakesh R