[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7986: Web Console: add Group by interval to segments view

[GitBox <gi...@apache.org>]

vogievetsky commented on a change in pull request #7986: Web Console: add Group by interval to segments view
URL: https://github.com/apache/incubator-druid/pull/7986#discussion_r298445736
 
 

 ##########
 File path: web-console/src/views/segments-view/segments-view.tsx
 ##########
 @@ -315,9 +346,16 @@ export class SegmentsView extends React.PureComponent<SegmentsViewProps, Segment
         onFilteredChange={(filtered, column) => {
           this.setState({ segmentFilter: filtered });
         }}
-        onFetchData={noSqlMode ? this.fecthClientSideData : this.fetchData}
+        onFetchData={
+          noSqlMode
+            ? this.fetchClientSideData
+            : groupSegmentsBy
+            ? this.fetchGroupData
+            : this.fetchData
 
 Review comment:
   you should just have one fetch data function and it should condition on `groupSegmentsBy`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org