You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/07/26 21:57:40 UTC

[GitHub] [tvm] cconvey opened a new pull request, #12194: [runtime][hexagon] improved file-copy logic

cconvey opened a new pull request, #12194:
URL: https://github.com/apache/tvm/pull/12194

   - Add `tvm::runtime::CopyFile` function.
   
   - Change `HexagonModuleNode::SaveToFile` to use new function
     instead of a shell `cp` invocation.
   
     This fixes a problem where the `cp`-based implementation
     couldn't handle certain valid filenames.
   
     This also fixes a bug where `SaveToFile` simply skips the
     file-copying step on Mac OSX.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] jwfromm merged pull request #12194: [runtime][hexagon] improved file-copy logic

Posted by GitBox <gi...@apache.org>.
jwfromm merged PR #12194:
URL: https://github.com/apache/tvm/pull/12194


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] cconvey commented on pull request #12194: [runtime][hexagon] improved file-copy logic

Posted by GitBox <gi...@apache.org>.
cconvey commented on PR #12194:
URL: https://github.com/apache/tvm/pull/12194#issuecomment-1196023022

   CC: @kparzysz-quic @csullivan 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] jwfromm commented on pull request #12194: [runtime][hexagon] improved file-copy logic

Posted by GitBox <gi...@apache.org>.
jwfromm commented on PR #12194:
URL: https://github.com/apache/tvm/pull/12194#issuecomment-1197093860

   Thanks @cconvey!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org