[GitHub] [ozone] Xushaohong commented on a change in pull request #2840: HDDS-5976. add raftlog IOException notifier for SCM ratis

[GitBox <gi...@apache.org>]

Xushaohong commented on a change in pull request #2840:
URL: https://github.com/apache/ozone/pull/2840#discussion_r751998578



##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMStateMachine.java
##########
@@ -175,6 +176,14 @@ private Message process(final SCMRatisRequest request) throws Exception {
     }
   }
 
+  @Override
+  public void notifyLogFailed(Throwable ex,
+                              RaftProtos.LogEntryProto failedEntry) {
+    // Should we add retry here?
+    LOG.error("SCM statemachine appendLog failed, entry: {}", failedEntry);
+    ExitUtil.terminate(1, ex);

Review comment:
       Thx for @JacksonYao287, I have replaced it with your suggestion.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org